Review main Abandoned

60238[BUGFIX] Drop broken dependency of $SOBE in DatabaseRecordList

Andreas Kienast CR 0 V 0 Normal +40 −36 updated 05/10/19, 15:16

Commit message

The class `\TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList` had
dependencies on $SOBE which are not fulfilled anymore. The class
now gets the used properties passed as constructor arguments, any
usage of $SOBE has been dropped.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 03/13/19, 15:59

  2. TYPO3com voted on patch set 1 V -1 03/13/19, 16:15 Completed build in 15m 20s on Wed, 13 Mar, 05:15 PM Test Summary: 3 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32703

  3. Andreas Kienast uploaded patch set 2 03/13/19, 18:41

  4. TYPO3com voted on patch set 2 V +1 03/13/19, 18:54 Completed build in 13m 25s on Wed, 13 Mar, 07:54 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32711

  5. Benni Mack commented on patch set 2 03/23/19, 21:36

    Doesn't this make the TableListViewHelper kind of... broken?
  6. Andreas Kienast commented on patch set 2 CR -1 03/23/19, 21:39

    > Patch Set 2: > > Doesn't this make the TableListViewHelper kind of... broken? I'm not sure. The introduced arguments in DatabaseRecordList are optional and 'SOBE' is semi-deprecated. This needs more investigation.
  7. Andreas Kienast abandoned the change 05/10/19, 15:16