Review main Merged

60242[TASK] Add tests for pages.slug in workspaces tests

Benni Mack CR +2 V +2 Hard +312 −312 updated 04/12/19, 17:44

Commit message

In order to see the current behaviour in
workspaces when modifying pages, the slug
field is added to the existing "Regular"
DataHandler tests within workspaces.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 45

Show 25 more files

Review log 79

  1. Benni Mack uploaded patch set 1 03/13/19, 17:44

  2. TYPO3com voted on patch set 1 V -1 03/13/19, 17:57 Completed build in 12m 49s on Wed, 13 Mar, 06:57 PM Test Summary: 15 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32709

  3. Oliver Hader commented on patch set 1 03/13/19, 19:13

    changePageSorting.csv:8 Unresolved

    Not sure whether we need the slug to be part of the move-placeholder, the relevant information is stored in the pointer record (t3ver_state=4), uid=91 in this example. Otherwise `shadowColumnsForMovePlaceholders` would have to be defined for pages' slug field...
  4. Benni Mack uploaded patch set 2 04/11/19, 00:13

  5. TYPO3com voted on patch set 2 V +1 04/11/19, 00:28 Completed build in 14m 51s on Thu, 11 Apr, 02:28 AM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33188

  6. Oliver Hader voted on patch set 2 V +1 CR +1 04/12/19, 16:56

  7. Oliver Hader commented on patch set 2 04/12/19, 16:57

    Looks good, thanks for maintaining that change!
  8. Georg Ringer voted on patch set 2 V +2 CR +2 04/12/19, 17:44

  9. Georg Ringer merged patch set 3 04/12/19, 17:44