Review main Merged

60244[TASK] Remove and streamline HMENU functionality

Benni Mack CR +2 V +2 Hard +118 −251 updated 03/23/19, 21:42

Commit message

HMENU was hardened during v9 via deprecations of
GMENU and making most of the properties protected.

Therefore, code can now refactored more easily.

- The method signatures for HMENU / TMENU are
streamlined.
- All leftover "RO" (RollOver) functionality is
removed (Breaking RST is already done but left-over
code was forgotten).
- Several GeneralUtility::inList() checks are replaced
with in_array()
- Some minor strict types for some internal obvious
methods
- use json_encode() instead of serialize()
for cache identifiers
- resolve some very very nested if() statements
- internal methods with "optional arguments" which
are always called with all arguments, are built
in a way that they are now non-optional.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 913

  1. Benni Mack uploaded patch set 1 03/13/19, 20:07

  2. TYPO3com voted on patch set 1 V -1 03/13/19, 20:20 Completed build in 13m 27s on Wed, 13 Mar, 09:20 PM Test Summary: 60 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32713

  3. Benni Mack uploaded patch set 2 03/13/19, 20:44

  4. TYPO3com voted on patch set 2 V +1 03/13/19, 20:58 Completed build in 13m 22s on Wed, 13 Mar, 09:58 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32714

  5. Benni Mack updated the commit message in patch set 3 03/14/19, 07:15

  6. Susi Moog voted on patch set 3 CR +1 03/14/19, 07:20

  7. TYPO3com voted on patch set 3 V +1 03/14/19, 07:28 Completed build in 13m 14s on Thu, 14 Mar, 08:28 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32716

  8. Andreas Kienast commented on patch set 3 CR -1 03/14/19, 08:36

    AbstractMenuContentObject.php:64 Unresolved

    PageRepository::DOKTYPE_BE_USER_SECTION

    AbstractMenuContentObject.php:221 Unresolved

    The condition is changed as mconf has a different value

    AbstractMenuContentObject.php:1211 Unresolved

    Wrong comment IMO, $this->excludedDoktypes doesn't contain Backend User Section only.
  9. Benni Mack uploaded patch set 4 03/16/19, 21:40

  10. TYPO3com voted on patch set 4 V +1 03/16/19, 21:59 Completed build in 16m 37s on Sat, 16 Mar, 10:59 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32801

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 03/23/19, 21:34

  12. Georg Ringer voted on patch set 4 V +2 CR +2 03/23/19, 21:41

  13. Georg Ringer merged patch set 5 03/23/19, 21:42