60244[TASK] Remove and streamline HMENU functionality
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php3+98 −194
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+8 −9
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+11 −47
Review log 913
-
Benni Mack uploaded patch set 1 03/13/19, 20:07
-
TYPO3com voted on patch set 1 V -1 03/13/19, 20:20 Completed build in 13m 27s on Wed, 13 Mar, 09:20 PM Test Summary: 60 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32713
-
Benni Mack uploaded patch set 2 03/13/19, 20:44
-
TYPO3com voted on patch set 2 V +1 03/13/19, 20:58 Completed build in 13m 22s on Wed, 13 Mar, 09:58 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32714
-
Benni Mack updated the commit message in patch set 3 03/14/19, 07:15
-
Susi Moog voted on patch set 3 CR +1 03/14/19, 07:20
-
TYPO3com voted on patch set 3 V +1 03/14/19, 07:28 Completed build in 13m 14s on Thu, 14 Mar, 08:28 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32716
-
Andreas Kienast commented on patch set 3 CR -1 03/14/19, 08:36
AbstractMenuContentObject.php:221UnresolvedThe condition is changed as mconf has a different valueAbstractMenuContentObject.php:1211UnresolvedWrong comment IMO, $this->excludedDoktypes doesn't contain Backend User Section only. -
Benni Mack uploaded patch set 4 03/16/19, 21:40
-
TYPO3com voted on patch set 4 V +1 03/16/19, 21:59 Completed build in 16m 37s on Sat, 16 Mar, 10:59 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32801
-
Andreas Kienast voted on patch set 4 V +1 CR +1 03/23/19, 21:34
-
Georg Ringer voted on patch set 4 V +2 CR +2 03/23/19, 21:41
-
Georg Ringer merged patch set 5 03/23/19, 21:42
AbstractMenuContentObject.php:64Unresolved