Review main Merged

60245[BUGFIX] Fix broken TS build due to outdated patch

Andreas Kienast CR +2 V +2 Easy +7 −7 updated 03/14/19, 09:23

Commit message

The patch for issue #87324 was based on outdated tslint configuration,
which causes all TypeScript builds to fail. The build is now fixed
by executing

    cd Build
    ./node_modules/tslint/bin/tslint -c tslint.json --fix --project .

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2

Issues 2

Files 6

Review log 46

  1. Andreas Kienast uploaded patch set 1 03/14/19, 09:06

  2. Andreas Kienast updated the commit message in patch set 2 03/14/19, 09:10

  3. TYPO3com voted on patch set 1 V +1 03/14/19, 09:18 Completed build in 11m 05s on Thu, 14 Mar, 10:18 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32718

  4. Andreas Kienast voted on patch set 2 V +2 CR +2 03/14/19, 09:18

  5. Andreas Kienast merged patch set 3 03/14/19, 09:18

  6. TYPO3com voted on patch set 2 V +1 03/14/19, 09:23 Completed build in 13m 02s on Thu, 14 Mar, 10:23 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32719