Review main Abandoned

60246[BUGFIX] Fix broken data and additionalAttributes on YouTubeRenderer

Sascha Egerer CR 0 V 0 Easy +3 −4 updated 03/14/19, 13:44

Commit message

Since the security fix in a32a9a746f807b14571139f0cb7caa00b8d037a5 the
YouTube renderer did not handle additionalAttributes and
options="{data: X}" anymore in a correct way. The resulting HTML was
broken.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Sascha Egerer uploaded patch set 1 03/14/19, 13:04

  2. Sascha Egerer updated the commit message in patch set 2 03/14/19, 13:05

  3. TYPO3com voted on patch set 1 V -1 03/14/19, 13:19 Completed build in 15m 31s on Thu, 14 Mar, 02:19 PM Test Summary: 112 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32724

  4. TYPO3com voted on patch set 2 V -1 03/14/19, 13:20 Completed build in 14m 55s on Thu, 14 Mar, 02:20 PM Test Summary: 112 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32725

  5. Sascha Egerer uploaded patch set 3 03/14/19, 13:36

  6. Sascha Egerer abandoned the change 03/14/19, 13:44

    Issue occured only due to a backport to my TYPO3 8.7 version. Master works fine