Review main Abandoned

60247[BUGFIX] Do not add "playlist" param in YouTubeRenderer if loop is set

Sascha Egerer CR 0 V 0 Easy +2 −2 updated 03/14/19, 19:17

Commit message

If the YouTube renderer renders a tag with a truthy "loop" argument
it must not add a playlist argument automatically. This was only
required for the old AS3 flash youtube player.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 34

  1. Sascha Egerer uploaded patch set 1 03/14/19, 16:21

  2. TYPO3com voted on patch set 1 V +1 03/14/19, 16:35 Completed build in 13m 05s on Thu, 14 Mar, 05:35 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32728

  3. Sascha Egerer commented on patch set 1 03/14/19, 19:17

    Ok lets keep it as it is. YouTube is really not doing what the API says. The loop does not work if you do only define a video with the loop parameter. You can define no video in the url and the video as playlist but in this case the autoplay does not work. So looks like the current state of youtube is that we have to live with the playlist overlay in the video that contains the same video 2 times
  4. Sascha Egerer abandoned the change 03/14/19, 19:17