Review main Merged

60249[TASK] Remove deprecated options in YouTube iFrame API

Sascha Egerer CR +2 V +2 Normal +39 −41 updated 07/12/19, 09:57

Commit message

The YouTube renderer added options to the YouTube url that
do not have any effect anymore as they are deprecrated since ages.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Guido Schmechel +1
    • Julian Geils +1
    • Frank Nägler +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Julian Geils +1
    • Frank Nägler +1
    • Jörg Bösche +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2428

Show 3 earlier messages
  1. Sascha Egerer uploaded patch set 1 03/14/19, 16:57

  2. Sascha Egerer commented on patch set 1 03/14/19, 16:59

    The behavior for an (invalid) negative "controls" value has slightly changes. Not sure if this is ok as it could be breaking but IMO it's not that important as it will not really break anything and only occurs if the place where it is used is broken anyway a bit...
  3. Sascha Egerer updated the commit message in patch set 2 03/14/19, 17:00

  1. TYPO3com voted on patch set 1 V +1 03/14/19, 17:12 Completed build in 15m 12s on Thu, 14 Mar, 06:12 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32729

  2. TYPO3com voted on patch set 2 V -1 03/14/19, 17:14 Completed build in 14m 06s on Thu, 14 Mar, 06:14 PM Test Summary: 2 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32730

  3. TYPO3com voted on patch set 2 V +1 03/14/19, 17:19 Completed build in 33m 39s on Thu, 14 Mar, 06:19 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32730

  4. Wolfgang Klinger voted on patch set 2 CR +1 03/15/19, 22:00

  5. Frank Nägler commented on patch set 2 CR -1 03/22/19, 21:09

    maybe I am blind (or stupid?) but I can't find any hint that showinfo or options are deprecated or not usable anymore. Can you please point me in the right direction?
  6. Wolfgang Klinger commented on patch set 2 03/23/19, 17:49

  7. Sascha Egerer commented on patch set 2 03/23/19, 21:33

    Looks like the german page is totally out of date. Please check the English API website and you‘ll the infos.
  8. Tobi Kretschmann commented on patch set 2 04/08/19, 14:26

    YouTubeRenderer.php:119

    just to clarify: we want to have a boolean false result in "controls=1" because the api asks for 1 or 0, not for true or false, correct?
  9. Sascha Egerer commented on patch set 2 04/08/19, 14:31

    YouTubeRenderer.php:119 Reply

    Correct, allowed values are "0" or "1"
  10. Tobi Kretschmann voted on patch set 2 V +1 CR +1 04/08/19, 16:02

  11. Guido Schmechel commented on patch set 2 04/09/19, 16:13

    YouTubeRenderer.php:119 Reply

    Do we need this complex check? RelatedVideos has the same values and the check seems to be much more readable.
  12. Markus Klein commented on patch set 2 07/10/19, 10:25

    YouTubeRenderer.php:119 Reply Unresolved

    My proposal: $options['controls'] = (int)!empty($options['controls']);
  13. Jörg Bösche uploaded patch set 3 07/10/19, 12:59

  14. TYPO3com voted on patch set 3 V +1 07/10/19, 13:10 Completed build in 10m 55s on Wed, 10 Jul, 03:10 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34888

  15. Tobi Kretschmann voted on patch set 3 V +1 CR +1 07/11/19, 07:21

  16. Julian Geils voted on patch set 3 V +1 CR +1 07/11/19, 12:15

  17. Guido Schmechel voted on patch set 3 CR +1 07/11/19, 12:19

  18. Steffen Frese voted on patch set 3 V +1 CR +1 07/11/19, 12:50

  19. Jörg Bösche voted on patch set 3 V +1 CR +1 07/12/19, 09:19

  20. Frank Nägler commented on patch set 3 CR -1 07/12/19, 09:37

    on testing, temporary -1
  21. Markus Klein commented on patch set 3 07/12/19, 09:54

    YouTubeRenderer.php:118 Unresolved

    IMO this variable is useless now.
  22. Frank Nägler voted on patch set 3 V +2 CR +2 07/12/19, 09:54

  23. Frank Nägler voted on patch set 3 V +1 CR +1 07/12/19, 09:54

  24. Tobi Kretschmann voted on patch set 3 V +2 CR +2 07/12/19, 09:57

  25. Tobi Kretschmann merged patch set 4 07/12/19, 09:57