Review main Merged

60252[TASK] Remove @internal from ConnectionPool::resetConnections()

Bernhard Sirlinger CR +2 V +2 Easy +2 −4 updated 03/22/19, 21:12

Commit message

The method ConnectionPool::resetConnections() is no longer annotated as
@internal. This reflects that it is necessary to reset connections in a
scheduler task spawning new child processes. This circumvents errors on
accessing a connection that has already been closed.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1420

  1. Bernhard Sirlinger uploaded patch set 1 03/14/19, 19:53

  2. TYPO3com voted on patch set 1 V +1 03/14/19, 20:11 Completed build in 16m 56s on Thu, 14 Mar, 09:11 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32735

  3. Bernhard Sirlinger updated the commit message in patch set 2 03/14/19, 20:32

  4. Stephan Großberndt updated the commit message in patch set 3 03/14/19, 20:39

  5. TYPO3com voted on patch set 2 V +1 03/14/19, 20:50 Completed build in 17m 48s on Thu, 14 Mar, 09:50 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32738

  6. TYPO3com voted on patch set 3 V +1 03/14/19, 20:50 Completed build in 10m 34s on Thu, 14 Mar, 09:50 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32740

  7. Aimeos voted on patch set 3 V +1 CR +1 03/15/19, 09:34

  8. Oliver Klee voted on patch set 3 CR +1 03/15/19, 11:57

  9. Björn Jacob commented on patch set 3 03/17/19, 18:50

    Please correct this sentence. I don't get it. False grammar. Thx!
  10. Stephan Großberndt updated the commit message in patch set 4 03/17/19, 19:03

  11. Stephan Großberndt commented on patch set 4 CR +1 03/17/19, 19:04

    Reply

    Done
  12. Stephan Großberndt updated the commit message in patch set 5 03/17/19, 19:04

  13. Oliver Klee updated the commit message in patch set 6 03/17/19, 19:14

  14. Oliver Klee voted on patch set 6 CR +1 03/17/19, 19:14

  15. TYPO3com voted on patch set 4 V +1 03/17/19, 19:15 Completed build in 11m 29s on Sun, 17 Mar, 08:15 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32828

  16. TYPO3com voted on patch set 5 V +1 03/17/19, 19:21 Completed build in 16m 14s on Sun, 17 Mar, 08:21 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32829

  17. TYPO3com voted on patch set 6 V +1 03/17/19, 19:29 Completed build in 14m 20s on Sun, 17 Mar, 08:29 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32830

  18. Benni Mack voted on patch set 6 V +1 CR +1 03/22/19, 21:11

  19. Frank Nägler voted on patch set 6 V +2 CR +2 03/22/19, 21:12

  20. Frank Nägler merged patch set 7 03/22/19, 21:12