Review main Merged

60259[BUGFIX] Check if field exists when deleting items from `group` field

Andreas Kienast CR +2 V +2 Easy +5 −3 updated 03/15/19, 14:00

Commit message

Fields of type `group` don't have a visible counterpart as opposed to
`selectMultipleSideBySide`. Thus, we have to check whether such field
exists before trying to interact with that field.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 03/15/19, 13:35

  2. Frank Nägler voted on patch set 1 CR +1 03/15/19, 13:47

  3. Frank Nägler voted on patch set 1 V +1 03/15/19, 13:49

  4. Frank Nägler wrote 03/15/19, 13:49

    Topic set to TypeScript
  5. Susi Moog voted on patch set 1 CR +1 03/15/19, 13:50

  6. TYPO3com voted on patch set 1 V +1 03/15/19, 13:56 Completed build in 18m 07s on Fri, 15 Mar, 02:56 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32756

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 03/15/19, 14:00

  8. Andreas Kienast merged patch set 2 03/15/19, 14:00