Review main Abandoned

60265[WIP][BUGFIX] Fix site resolution for versioned page moves across sites

Benjamin Franzke CR 0 V 0 Normal +69 −32 updated 11/04/21, 14:42

Commit message

The site finder is now able to derive sites by the uid of
a possible workspace move pointer record (VersionState::MOVE_POINTER).
The logic is implemented behind the scenes in PageRepository
and RootlineUtility.

PageRepository is adapted to properly invoke getMovePlaceholder()
using the original uid (t3ver_oid), instead of the move pointer record uid
(BackendUtility:fixVersioningPid already does so as well).

TODO:
 * Split wrong call from PageRepository::fixVersioningPid to
   getMovePlaceholder() into a separate patch
   (PageRepository::fixVersioningPid is broken, while
   BackendUtility::fixVersioningPid is not)
 * Should we renmame movePlhOL (=movePlaceholderOverlay) to a different
   name (covering both MOVE_PLACEHOLDER and MOVE_POINTER), e.g.
   moveOverlay
   Or should we move the functonality to handle MOVE_POINTER into a
   different function(?)
 * Maybe adapt BackendUtility::movePlhOl as well?
 * Add tests

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 812

  1. Benjamin Franzke uploaded patch set 1 03/16/19, 06:29

  2. TYPO3com voted on patch set 1 V -1 03/16/19, 06:29 Completed build in 06s on Sat, 16 Mar, 07:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32777

  3. Benjamin Franzke marked it work in progress 03/16/19, 06:32

  4. Benjamin Franzke uploaded patch set 2 03/16/19, 06:32

  5. TYPO3com commented on patch set 2 03/16/19, 06:32 Completed build in 07s on Sat, 16 Mar, 07:32 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32779

  6. Benjamin Franzke updated the commit message in patch set 3 03/16/19, 07:07

  7. TYPO3com voted on patch set 3 V -1 03/16/19, 07:07 Completed build in 10s on Sat, 16 Mar, 08:07 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32781

  8. Benjamin Franzke uploaded patch set 4 03/25/19, 15:49

  9. Benjamin Franzke wrote 03/25/19, 15:50

    Topic set to workspaces
  10. TYPO3com voted on patch set 4 V -1 03/25/19, 16:06 Completed build in 16m 49s on Mon, 25 Mar, 05:06 PM Test Summary: 1 of 47650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32958

  11. Benni Mack commented on patch set 4 07/29/21, 19:32

    I think we can abandon this change, as this has been solved with TYPO3 v11 by removing the move placeholders now.
  12. Benni Mack abandoned the change 11/04/21, 14:42

    abandoned for the reasons mentioned