Review main Abandoned

60266[BUGFIX] Respect disablePrependAtCopy in allowLanguageSynchronization

Georg Ringer CR 0 V 0 Easy +6 −2 updated 10/19/21, 18:56

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 710

  1. Georg Ringer uploaded patch set 1 03/16/19, 07:19

  2. Georg Ringer commented on patch set 1 03/16/19, 07:20

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/16/19, 07:33 Completed build in 13m 57s on Sat, 16 Mar, 08:33 AM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32782

  4. Jörg Bösche commented on patch set 1 V -1 CR -1 04/09/19, 08:06

    DataMapProcessor.php:1329

    Wrong line sorting? - $tsConfig is undefined. Move 1-2 lines down.

    DataMapProcessor.php:1340

    Because of skipping the prefix generation, the empty check is true and defines the prefix again. This will give us a prefixed field in the following iteration. Or the translate to process should directly skipped, if the whole table ($tableEntries['disablePrependAtCopy']) has the setting "disablePrependAtCopy".
  5. Benni Mack uploaded patch set 2 12/27/19, 20:47

  6. TYPO3com voted on patch set 2 V +1 12/27/19, 20:57 Completed build in 10m 18s on Fri, 27 Dec, 08:57 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39611

  7. Oliver Hader commented on patch set 2 CR -1 12/28/19, 09:11

    * (static) `getTableEntries` should rather be moved to e.g. a new `BackendUtility::getTSconfigTableEntries()` in order to avoid nested DataHandler instances * there should be functional tests...
  8. Benni Mack updated the commit message in patch set 3 05/25/20, 18:42

  9. TYPO3com voted on patch set 3 V -1 05/25/20, 19:09 Completed build in 20m 49s on Mon, 25 May, 07:09 PM Test Summary: 73797 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3526

  10. Georg Ringer abandoned the change 10/19/21, 18:56

    abandoned, no interest