Review main Abandoned

60270[BUGFIX] Catch UnknownLinkHandler exception during backend editing

Georg Ringer CR 0 V 0 Easy +10 −7 updated 02/27/20, 13:39

Commit message

Catch an exception which is thrown if an unkown linkhandler is
used during creating content with the ckeditor.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 03/16/19, 11:19

  2. Georg Ringer commented on patch set 1 03/16/19, 11:20

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/16/19, 11:33 Completed build in 13m 44s on Sat, 16 Mar, 12:33 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32788

  4. Wolfgang Klinger voted on patch set 1 V +1 CR +1 03/16/19, 11:42

  5. Josef Glatz commented on patch set 1 CR -2 03/16/19, 22:54

    > Works like described! 1. How should we handle the broken frontend rendering? 2. Should we highlight an <a> tag only with a href value "t3://"
  6. Josef Glatz commented on patch set 1 03/20/19, 10:34

    > Patch Set 1: Code-Review-2 > > > Works like described! > > 1. How should we handle the broken frontend rendering? > 2. Should we highlight an <a> tag only with a href value "t3://" I like the idea from Wolfgang: Don't render the link in FE (empty href OR completely remove the A-tag (and leave the child text)) A LinkValidator must be in place to check for wrong/unknown linkhandlers in existing content. What is the opinion of others in this area?
  7. Guido Schmechel commented on patch set 1 03/20/19, 21:00

    After a first research, it seems to be no problem to have an empty link for seo. But an editor may not discover the mistake if he sees the link as normal. In the past, broken links were marked ugly. My favourite: Remove the a Tag, log a warning and extend the linkvalidator
  8. Benni Mack uploaded patch set 2 11/09/19, 14:40

  9. Benni Mack commented on patch set 2 11/09/19, 14:40

    > Patch Set 1: > > After a first research, it seems to be no problem to have an empty link for seo. But an editor may not discover the mistake if he sees the link as normal. In the past, broken links were marked ugly. > > My favourite: Remove the a Tag, log a warning and extend the linkvalidator We've extended linkvalidator for more usecases and now have an event in place to handle this.
  10. TYPO3com voted on patch set 2 V +1 11/09/19, 14:48 Completed build in 08m 26s on Sat, 9 Nov, 02:48 PM Test Summary: 48243 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38188

  11. Georg Ringer abandoned the change 02/27/20, 13:39