Review 9.5 Merged

60271[BUGFIX] Ensure result is string in __toString of CropVariantCollection

Daniel Goerz CR +2 V +2 Easy +10 −1 updated 03/16/19, 12:10

Commit message

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Daniel Goerz commented on patch set 1 03/16/19, 11:24

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/16/19, 11:40 Completed build in 15m 15s on Sat, 16 Mar, 12:40 PM Test Summary: 1 of 50400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-389

  3. TYPO3com voted on patch set 1 V +1 03/16/19, 11:58 Completed build in 49m 04s on Sat, 16 Mar, 12:58 PM Test Summary: 49932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-389

  4. Daniel Goerz voted on patch set 1 V +2 CR +2 03/16/19, 12:10

  5. Daniel Goerz merged patch set 2 03/16/19, 12:10