Review main Merged Breaking

60273[!!!][TASK] Remove TCA for sys_history

Benni Mack CR +2 V +2 Normal +46 −50 updated 03/17/19, 13:21

Commit message

TCA for sys_history is not necessary at all anymore, and
can be removed.

It was previously used for creating an Extbase Domain Model
for the BELog module created in TYPO3 6.0/6.1.

However, in 9.0 sys_history was decoupled from sys_log,
whereas the Domain Model and the usages for TCA was
not necessary anymore.

The previously "generated" database fields are re-added
manually in ext_tables.sql. The field "pid" which was necessary
for a TCA table is now dropped.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1114

  1. Benni Mack uploaded patch set 1 03/16/19, 18:48

  2. TYPO3com voted on patch set 1 V -1 03/16/19, 18:57 Completed build in 07m 58s on Sat, 16 Mar, 07:57 PM Test Summary: 6227 of 47517 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32793

  3. Benni Mack uploaded patch set 2 03/16/19, 20:16

  4. TYPO3com voted on patch set 2 V +1 03/16/19, 20:25 Completed build in 09m 46s on Sat, 16 Mar, 09:25 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32795

  5. Josef Glatz commented on patch set 2 03/16/19, 22:31

    Breaking-87936-TCAForSysHistoryRemoved.rst:36

    What do you think about an ready2use 3rd party ext for that?

    ext_tables.sql:336

    What's the reason for leaving the SQL for sys_history table?
  6. Benni Mack commented on patch set 2 03/16/19, 23:07

    Breaking-87936-TCAForSysHistoryRemoved.rst:36 Reply

    Main issue is: I can hardly think of a use case why this is needed at all - adding this to TCA causes some side effects (see the "disable this table in refindex"). I did lots of digging until 4.7/6.0 when this was added and the only reason was for using it in BElog with Extbase (making it slow).

    ext_tables.sql:336 Reply

    well, we still use the DB table and its queries, but not for TCA (= list module etc.). So the DB table is just a regular table like 'fe_sessions' for example, where we don't have TCA as well.
  7. Josef Glatz commented on patch set 2 03/17/19, 07:40

    Thanks for explaining!

    Breaking-87936-TCAForSysHistoryRemoved.rst:36 Reply

    Ack

    ext_tables.sql:336 Reply

    Done
  8. Benni Mack commented on patch set 2 03/17/19, 11:14

    ext_tables.sql:336 Reply

    Done
  9. Anja Leichsenring commented on patch set 3 03/17/19, 12:19

    Published edit on patch set 2.
  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/17/19, 12:20

  11. TYPO3com voted on patch set 3 V +1 03/17/19, 12:33 Completed build in 13m 42s on Sun, 17 Mar, 01:33 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32820

  12. Alexander Schnitzler voted on patch set 3 V +1 CR +1 03/17/19, 13:05

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 03/17/19, 13:21

  14. Daniel Goerz merged patch set 4 03/17/19, 13:21