60273[!!!][TASK] Remove TCA for sys_history
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_history.phpdeleted+0 −49
- typo3/sysext/core/Documentation/Changelog/master/Breaking-87936-TCAForSysHistoryRemoved.rst3new+38 −0
- typo3/sysext/core/ext_tables.sql4+3 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
Review log 1114
-
Benni Mack uploaded patch set 1 03/16/19, 18:48
-
TYPO3com voted on patch set 1 V -1 03/16/19, 18:57 Completed build in 07m 58s on Sat, 16 Mar, 07:57 PM Test Summary: 6227 of 47517 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32793
-
Benni Mack uploaded patch set 2 03/16/19, 20:16
-
TYPO3com voted on patch set 2 V +1 03/16/19, 20:25 Completed build in 09m 46s on Sat, 16 Mar, 09:25 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32795
-
Josef Glatz commented on patch set 2 03/16/19, 22:31
ext_tables.sql:336What's the reason for leaving the SQL for sys_history table? -
Benni Mack commented on patch set 2 03/16/19, 23:07
Breaking-87936-TCAForSysHistoryRemoved.rst:36ReplyMain issue is: I can hardly think of a use case why this is needed at all - adding this to TCA causes some side effects (see the "disable this table in refindex"). I did lots of digging until 4.7/6.0 when this was added and the only reason was for using it in BElog with Extbase (making it slow).ext_tables.sql:336Replywell, we still use the DB table and its queries, but not for TCA (= list module etc.). So the DB table is just a regular table like 'fe_sessions' for example, where we don't have TCA as well. -
Josef Glatz commented on patch set 2 03/17/19, 07:40
Thanks for explaining!Breaking-87936-TCAForSysHistoryRemoved.rst:36ReplyAckext_tables.sql:336ReplyDone -
Benni Mack commented on patch set 2 03/17/19, 11:14
ext_tables.sql:336ReplyDone -
Anja Leichsenring commented on patch set 3 03/17/19, 12:19
Published edit on patch set 2. -
Anja Leichsenring voted on patch set 3 V +1 CR +1 03/17/19, 12:20
-
TYPO3com voted on patch set 3 V +1 03/17/19, 12:33 Completed build in 13m 42s on Sun, 17 Mar, 01:33 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32820
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 03/17/19, 13:05
-
Daniel Goerz voted on patch set 3 V +2 CR +2 03/17/19, 13:21
-
Daniel Goerz merged patch set 4 03/17/19, 13:21
Breaking-87936-TCAForSysHistoryRemoved.rst:36