Review main Merged Breaking

60274[!!!][TASK] Remove support for "selicon_field_path" option

Benni Mack CR +2 V +2 Normal +95 −43 updated 03/23/19, 20:29

Commit message

The TCA[ctrl][selicon_field_path] option is not necessary
anymore, as support for "internal_type=file" was dropped
for v10.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1118

  1. Benni Mack uploaded patch set 1 03/16/19, 18:53

  2. TYPO3com voted on patch set 1 V -1 03/16/19, 19:03 Completed build in 09m 51s on Sat, 16 Mar, 08:03 PM Test Summary: 964 of 47594 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32794

  3. Josef Glatz updated the commit message in patch set 2 03/16/19, 20:36

  4. TYPO3com voted on patch set 2 V -1 03/16/19, 20:49 Completed build in 12m 23s on Sat, 16 Mar, 09:49 PM Test Summary: 3696 of 47594 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32796

  5. Benni Mack uploaded patch set 3 03/16/19, 21:03

  6. Benni Mack updated the commit message in patch set 4 03/16/19, 21:04

  7. TYPO3com voted on patch set 4 V -1 03/16/19, 21:16 Completed build in 12m 46s on Sat, 16 Mar, 10:16 PM Test Summary: 193 of 47598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32798

  8. TYPO3com voted on patch set 3 V -1 03/16/19, 21:19 Completed build in 15m 49s on Sat, 16 Mar, 10:19 PM Test Summary: 443 of 47598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32797

  9. Josef Glatz uploaded patch set 5 03/16/19, 21:35

  10. TYPO3com voted on patch set 5 V -1 03/16/19, 21:52 Completed build in 17m 18s on Sat, 16 Mar, 10:52 PM Test Summary: 592 of 47598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32799

  11. Benni Mack uploaded patch set 6 03/17/19, 12:11

  12. TYPO3com voted on patch set 6 V -1 03/17/19, 12:12 Completed build in 12s on Sun, 17 Mar, 01:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32819

  13. Benni Mack uploaded patch set 7 03/17/19, 12:31

  14. TYPO3com voted on patch set 7 V +1 03/17/19, 12:41 Completed build in 10m 27s on Sun, 17 Mar, 01:41 PM Test Summary: 47205 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32821

  15. Georg Ringer voted on patch set 7 V +1 CR +1 03/18/19, 07:22

  16. Josef Glatz voted on patch set 7 V +1 CR +1 03/23/19, 15:44

  17. Benni Mack voted on patch set 7 V +2 CR +2 03/23/19, 20:29

  18. Benni Mack merged patch set 8 03/23/19, 20:29