60275[BUGFIX] Use single instance of DocumentTypeExclusionRestriction
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Claus Due +1
- Andreas Kienast +1
- Dennis Prinse +1
-
Verified V +2 Done
- Richard Haeser +2
- Dennis Prinse +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1930
Show 35 earlier messages
-
Manuel Selbach uploaded patch set 1 03/16/19, 21:39
-
Manuel Selbach uploaded patch set 2 03/16/19, 21:42
-
Manuel Selbach wrote 03/16/19, 21:43
Topic set to persistence -
TYPO3com voted on patch set 1 V -1 03/16/19, 21:56 Completed build in 16m 32s on Sat, 16 Mar, 10:56 PM Test Summary: 25 of 47602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32800
-
TYPO3com voted on patch set 2 V -1 03/16/19, 22:03 Completed build in 21m 21s on Sat, 16 Mar, 11:03 PM Test Summary: 25 of 47602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32802
-
TYPO3com commented on patch set 1 03/16/19, 22:22 Completed build in 10s on Sat, 16 Mar, 11:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-393
-
TYPO3com commented on patch set 2 03/16/19, 22:38 Completed build in 19m 12s on Sat, 16 Mar, 11:38 PM Test Summary: 25 of 47602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32805
-
Manuel Selbach uploaded patch set 3 03/16/19, 22:42
-
TYPO3com commented on patch set 1 03/16/19, 22:51 Completed build in 28m 29s on Sat, 16 Mar, 11:51 PM Test Summary: 25 of 47602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32806
-
TYPO3com voted on patch set 3 V +1 03/16/19, 23:11 Completed build in 24m 19s on Sun, 17 Mar, 12:11 AM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32808
-
Georg Ringer commented on patch set 3 03/18/19, 06:42
So let's call it doktypes then? -
Oliver Klee commented on patch set 3 03/18/19, 10:20
TreeController.php:387Please let's have a type hint for the parameter.DocumentTypeExclusionRestrictionTest.php:41: void return type -
Manuel Selbach uploaded patch set 4 03/18/19, 13:47
-
TYPO3com voted on patch set 4 V -1 03/18/19, 13:47 Completed build in 10s on Mon, 18 Mar, 02:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32838
-
Manuel Selbach uploaded patch set 5 03/18/19, 15:58
-
TYPO3com voted on patch set 5 V -1 03/18/19, 16:13 Completed build in 15m 24s on Mon, 18 Mar, 05:13 PM Test Summary: 2 of 47602 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32841
-
TYPO3com voted on patch set 5 V +1 03/18/19, 17:12 Completed build in 16m 25s on Mon, 18 Mar, 06:12 PM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32842
-
Oliver Klee wrote 03/18/19, 17:37
Removed reviewer Oliver Klee. -
Susi Moog commented on patch set 5 CR -1 12/20/19, 07:33
DocumentTypeExclusionRestriction.php:34this is a breaking change as far as I can see, as calling it with an integer will now fail (and the class is not internal but public API) -
Richard Haeser commented on patch set 5 02/14/20, 12:08
DocumentTypeExclusionRestriction.php:34ReplyYes it is breaking indeed. But I would opt to have this at least in v10. We have a big challenge with an upgrade to v9 because this is not working. Best we can do is to have this in v10? This method now only works if you have only 1 excluded doktype and I guess people that use this option, are not hiding just 1 doktype so it is not working for them. -
Andreas Kienast commented on patch set 5 02/14/20, 13:13
DocumentTypeExclusionRestriction.php:34Reply UnresolvedDrop the type annotation and cast $doktypes to an array if necessary? -
Richard Haeser uploaded patch set 6 02/17/20, 13:04
-
TYPO3com voted on patch set 6 V -1 02/17/20, 13:05 Completed build in 22s on Mon, 17 Feb, 01:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-200
-
Richard Haeser uploaded patch set 7 02/17/20, 13:08
-
TYPO3com voted on patch set 7 V +1 02/17/20, 13:21 Completed build in 13m 10s on Mon, 17 Feb, 01:21 PM Test Summary: 71313 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-201
-
Dennis Prinse voted on patch set 7 V +1 CR +1 02/17/20, 14:30
-
Andreas Kienast voted on patch set 7 CR +1 02/17/20, 21:07
-
Claus Due commented on patch set 7 CR +1 02/17/20, 21:28
Okay for me although it technically is breaking. The saving grace is that `new` was used to instanciate the restriction object which means no XCLASS can be negatively affected by this patch, which would've been the one reason to reject this as potentially breaking. -
Richard Haeser voted on patch set 7 V +2 CR +2 02/17/20, 21:42
-
Richard Haeser merged patch set 8 02/17/20, 21:42