Review main Merged Breaking

60276[!!!][TASK] Remove TCA option setToDefaultOnCopy

Benni Mack CR +2 V +2 Normal +96 −5 updated 03/25/19, 08:13

Commit message

This special setting resets a certain field to its default
value when copying. This option was only there for
resetting some sys_action values to default, which can
easily be achieved by a hook if needed.

The option is removed to reduce the amount of checks and
the amount of available options for edge-cases in TCA, as this
option was not widely used - as identified by the Persistence
Initiative.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1015

  1. Benni Mack uploaded patch set 1 03/16/19, 23:11

  2. TYPO3com voted on patch set 1 V +1 03/16/19, 23:27 Completed build in 15m 15s on Sun, 17 Mar, 12:27 AM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32809

  3. Benni Mack uploaded patch set 2 03/23/19, 20:38

  4. TYPO3com voted on patch set 2 V -1 03/23/19, 20:51 Completed build in 12m 29s on Sat, 23 Mar, 09:51 PM Test Summary: 4 of 47614 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32906

  5. Benni Mack uploaded patch set 3 03/23/19, 21:05

  6. TYPO3com voted on patch set 3 V +1 03/23/19, 21:27 Completed build in 19m 17s on Sat, 23 Mar, 10:27 PM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32910

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 03/23/19, 21:56

  8. Daniel Goerz commented on patch set 4 03/24/19, 18:20

    Published edit on patch set 3.
  9. Daniel Goerz voted on patch set 4 V +1 CR +1 03/24/19, 18:20

  10. TYPO3com voted on patch set 4 V -1 03/24/19, 18:36 Completed build in 15m 12s on Sun, 24 Mar, 07:36 PM Test Summary: 1 of 47614 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32928

  11. Daniel Goerz updated the commit message in patch set 5 03/24/19, 18:45

  12. Daniel Goerz voted on patch set 5 V +1 CR +1 03/24/19, 18:46

  13. TYPO3com voted on patch set 5 V +1 03/24/19, 19:02 Completed build in 16m 04s on Sun, 24 Mar, 08:02 PM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32930

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 03/25/19, 08:13

  15. Andreas Kienast merged patch set 6 03/25/19, 08:13