Review main Merged

60292[BUGFIX] Re-enable target attribute for links in menus

Benni Mack CR +2 V +2 Easy +6 −1 updated 03/22/19, 20:42

Commit message

The new pagelink builder does not set the lastTypoLinkLD options
which is used in HMENUs. The patch properly sets
the lastTypoLink* properties of ContentObjectRenderer in typolink
again, making target overrides in menus work again.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 03/17/19, 11:09

  2. TYPO3com voted on patch set 1 V +1 03/17/19, 11:24 Completed build in 14m 27s on Sun, 17 Mar, 12:24 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32818

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/19/19, 06:52

  4. Frank Nägler voted on patch set 1 V +2 CR +2 03/22/19, 20:42

  5. Frank Nägler merged patch set 2 03/22/19, 20:42