60293[FEATURE] Introduce TCA type "language"
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Benni Mack +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 204
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+0 −48
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.phpnew+185 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+20 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.phpnew+638 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+0 −55
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −6
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+8 −15
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+34 −10
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Localization/TcaSystemLanguageCollector.php2+61 −0
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+73 −10
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −1
- typo3/sysext/core/Configuration/TCA/be_users.php+1 −1
- typo3/sysext/core/Configuration/TCA/pages.php+1 −10
- typo3/sysext/core/Configuration/TCA/sys_category.php+1 −11
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+1 −13
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+1 −13
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+1 −13
- typo3/sysext/core/Configuration/DefaultConfiguration.php2+7 −0
Show 184 more files
- typo3/sysext/core/Documentation/Changelog/master/Feature-57082-NewTCATypeLanguage.rst11new+101 −0
- typo3/sysext/core/Resources/Private/Language/locallang_general.xlf3+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SpecialLanguagesTest.phpdeleted+0 −69
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/copyContentToLanguage.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/localizeContent.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/copyContentToLanguageOfRelation.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/copyElementToLanguageOfRelation.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Group/Modify/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/copyParentContentToLanguageWithAllChildren.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizeNCopyPageWSynchronization.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageTwiceWExclude.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageWExclude.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageWSynchronization.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizeParentContentLanguageSynchronization.csv+0 −5
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/copyParentContentToLanguageWAllChildren.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeNCopyPageWSynchronization.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageTwiceWExclude.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageWExclude.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv+0 −3
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizePageWSynchronization.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv+0 −10
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csv+0 −7
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentSynchronization.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/core/Tests/Functional/DataHandling/ManyToMany/Modify/DataSet/localizeCategoryOfRelation.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguage.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageWExclude.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createContentForLanguageAll.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createLocalizedContent.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createLocalizedContentWExclude.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/createLocalizedContentWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/deleteLocalizedContentNDeleteContent.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContent.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationDefault.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationSource.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentWithEmptyTcaIntegrityColumns.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentWSynchronizationHNull.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeNCopyPage.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeNCopyPageWSynchronization.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeNestedPagesAndContents.csv+0 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizePage.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizePageWSynchronization.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/modifyTranslatedContent.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedToDifferentPageTwice.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/DataSet/copyElementToLanguageOfRelation.csv+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Select/Modify/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+1 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/tx_testdatahandler_element.php+1 −8
- typo3/sysext/core/Tests/Unit/Localization/TcaSystemLanguageCollectorTest.phpnew+137 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+145 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_blog.php+1 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_info.php+1 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+1 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+1 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php+1 −11
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+1 −0
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+1 −11
- typo3/sysext/frontend/Tests/Functional/Rendering/DataSet/LiveDefaultElements.csv+0 −6
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithImagesButNotIncluded.csv3+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithImagesButWithoutStorageOnCaseInsensitiveFilesystems.csv+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithImagesButWithoutStorageOnCaseSensitiveFilesystems.csv+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithImagesOnCaseInsensitiveFilesystems.csv+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithImagesOnCaseSensitiveFilesystems.csv+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-corrupt-image.xml+0 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image-but-not-included.xml+0 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/pages-and-ttcontent-with-image.xml+0 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-but-not-included.xml+0 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-without-storage.xml+0 −13
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image.xml+0 −13
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Discard/DataSet/localizeContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Modify/DataSet/localizeContent.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/Publish/DataSet/localizeContent.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/PublishAll/DataSet/localizeContent.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Discard/DataSet/localizeElementOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Modify/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/Publish/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/PublishAll/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/DataSet/localizeParentContentWAllChildren.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Discard/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Discard/DataSet/localizeParentContentWAllChildren.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csv+0 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/localizeParentContentWAllChildren.csv+0 −4
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Discard/DataSet/localizeCategoryOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Modify/DataSet/localizeCategoryOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/Publish/DataSet/localizeCategoryOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/PublishAll/DataSet/localizeCategoryOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/copyContentToLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/createContentAndLocalize.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/deleteLocalizedContentNDeleteContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/localizeContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/localizeContentFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/localizeNestedPagesAndContents.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createContentAndLocalize.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/createLocalizedNotHiddenWorkspaceContentHiddenInLive.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/deleteLocalizedContentNDeleteContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguage.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentWHideAtCopy.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentWithEmptyTcaIntegrityColumns.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeNestedPagesAndContents.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizePage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/copyContentToLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/createContentAndLocalize.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeContentFromNonDefaultLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeNestedPagesAndContents.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizePage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/copyContentToLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/copyContentToLanguageFromNonDefaultLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/createContentAndLocalize.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/deleteLocalizedContentNDeleteContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeContent.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeContentFromNonDefaultLanguage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeNestedPagesAndContents.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizePage.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedToDifferentPageTwice.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Discard/DataSet/localizeElementOfRelation.csv+0 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Modify/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/Publish/DataSet/localizeElementOfRelation.csv+0 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/PublishAll/DataSet/localizeElementOfRelation.csv+0 −2
Review log 3781
Show 2256 earlier messages
-
Benni Mack uploaded patch set 1 03/17/19, 14:03
-
TYPO3com voted on patch set 1 V -1 03/17/19, 14:18 Completed build in 14m 58s on Sun, 17 Mar, 03:18 PM Test Summary: 18 of 47598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32823
-
Benni Mack updated the commit message in patch set 2 04/09/19, 13:25
-
TYPO3com voted on patch set 2 V -1 04/09/19, 13:43 Completed build in 17m 08s on Tue, 9 Apr, 03:43 PM Test Summary: 18 of 47664 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33142
-
Benni Mack uploaded patch set 3 09/27/19, 14:27
-
TYPO3com voted on patch set 3 V -1 09/27/19, 14:37 Completed build in 10m 24s on Fri, 27 Sep, 02:37 PM Test Summary: 21 of 48079 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36902
-
Benni Mack rebased onto patch set 4 12/27/19, 06:25
-
TYPO3com voted on patch set 4 V -1 12/27/19, 06:33 Completed build in 07m 37s on Fri, 27 Dec, 06:33 AM Test Summary: 21 of 69584 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39578
-
Benni Mack abandoned the change 02/27/20, 11:03
-
Benni Mack restored the change 01/21/21, 07:01
-
Benni Mack uploaded patch set 5 01/21/21, 07:03
-
TYPO3com voted on patch set 5 V -1 01/21/21, 07:14 Completed build in 10m 46s on Thu, 21 Jan, 07:14 AM Test Summary: 587 of 32844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8951
-
Oli Bartsch rebased onto patch set 6 03/09/21, 21:49
-
TYPO3com voted on patch set 6 V -1 03/09/21, 21:57 Completed build in 07m 08s on Tue, 9 Mar, 09:57 PM Test Summary: 590 of 32918 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9993
-
core-ci voted on patch set 6 V -1 03/09/21, 22:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1348
-
Georg Ringer rebased onto patch set 7 03/11/21, 07:28
-
TYPO3com voted on patch set 7 V -1 03/11/21, 07:35 Completed build in 07m 01s on Thu, 11 Mar, 07:35 AM Test Summary: 590 of 32918 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10041
-
core-ci voted on patch set 7 V -1 03/11/21, 07:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1405
-
Oli Bartsch uploaded patch set 8 03/11/21, 23:59
-
TYPO3com voted on patch set 8 V -1 03/12/21, 00:07 Completed build in 07m 32s on Fri, 12 Mar, 12:07 AM Test Summary: 590 of 32952 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10066
-
core-ci voted on patch set 8 V -1 03/12/21, 00:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1438
-
Oli Bartsch uploaded patch set 9 03/12/21, 10:48
-
TYPO3com voted on patch set 9 V -1 03/12/21, 10:55 Completed build in 07m 09s on Fri, 12 Mar, 10:55 AM Test Summary: 402 of 32964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10072
-
core-ci voted on patch set 9 V -1 03/12/21, 11:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1450
-
Oli Bartsch uploaded patch set 10 03/12/21, 11:28
-
TYPO3com voted on patch set 10 V -1 03/12/21, 11:35 Completed build in 07m 05s on Fri, 12 Mar, 11:35 AM Test Summary: 261 of 32964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10074
-
core-ci voted on patch set 10 V -1 03/12/21, 11:44 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1452
-
Oli Bartsch uploaded patch set 11 03/12/21, 11:51
-
TYPO3com voted on patch set 11 V -1 03/12/21, 12:00 Completed build in 08m 51s on Fri, 12 Mar, 12:00 PM Test Summary: 18 of 32964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10076
-
core-ci voted on patch set 11 V -1 03/12/21, 12:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1454
-
Oli Bartsch uploaded patch set 12 03/12/21, 13:35
-
TYPO3com voted on patch set 12 V -1 03/12/21, 13:44 Completed build in 08m 27s on Fri, 12 Mar, 01:44 PM Test Summary: 9 of 32973 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10080
-
core-ci voted on patch set 12 V -1 03/12/21, 13:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1458
-
Oli Bartsch uploaded patch set 13 03/12/21, 16:09
-
TYPO3com voted on patch set 13 V +1 03/12/21, 16:16 Completed build in 07m 06s on Fri, 12 Mar, 04:16 PM Test Summary: 32735 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10089
-
core-ci voted on patch set 13 V +1 03/12/21, 16:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1466
-
Oli Bartsch uploaded patch set 14 03/12/21, 23:06
-
TYPO3com voted on patch set 14 V -1 03/12/21, 23:22 Completed build in 16m 22s on Fri, 12 Mar, 11:22 PM Test Summary: 4809 of 32959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10100
-
core-ci voted on patch set 14 V -1 03/12/21, 23:32 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1480
-
Oli Bartsch uploaded patch set 15 03/12/21, 23:59
-
TYPO3com voted on patch set 15 V -1 03/13/21, 00:16 Completed build in 16m 17s on Sat, 13 Mar, 12:16 AM Test Summary: 4804 of 32959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10101
-
core-ci voted on patch set 15 V -1 03/13/21, 00:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1481
-
Oli Bartsch uploaded patch set 16 03/15/21, 10:36
-
TYPO3com voted on patch set 16 V -1 03/15/21, 10:36 Completed build in 29s on Mon, 15 Mar, 10:36 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10137
-
Oli Bartsch uploaded patch set 17 03/15/21, 10:37
-
core-ci voted on patch set 16 V -1 03/15/21, 10:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1550
-
TYPO3com voted on patch set 17 V -1 03/15/21, 10:53 Completed build in 16m 04s on Mon, 15 Mar, 10:53 AM Test Summary: 4801 of 32961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10138
-
core-ci voted on patch set 17 V -1 03/15/21, 11:02 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1551
-
Oli Bartsch uploaded patch set 18 03/15/21, 11:33
-
TYPO3com voted on patch set 18 V +1 03/15/21, 11:39 Completed build in 06m 04s on Mon, 15 Mar, 11:39 AM Test Summary: 32725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10139
-
core-ci voted on patch set 18 V +1 03/15/21, 11:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1552
-
Oli Bartsch uploaded patch set 19 03/15/21, 16:57
-
TYPO3com voted on patch set 19 V -1 03/15/21, 17:03 Completed build in 06m 28s on Mon, 15 Mar, 05:03 PM Test Summary: 2 of 32965 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10142
-
core-ci voted on patch set 19 V -1 03/15/21, 17:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1558
-
Oli Bartsch uploaded patch set 20 03/15/21, 21:23
-
TYPO3com voted on patch set 20 V +1 03/15/21, 21:30 Completed build in 06m 54s on Mon, 15 Mar, 09:30 PM Test Summary: 32727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10146
-
core-ci voted on patch set 20 V +1 03/15/21, 21:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1563
-
Oli Bartsch updated the commit message in patch set 21 03/15/21, 22:18
-
TYPO3com voted on patch set 21 V +1 03/15/21, 22:25 Completed build in 06m 47s on Mon, 15 Mar, 10:25 PM Test Summary: 32727 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10147
-
core-ci voted on patch set 21 V +1 03/15/21, 22:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1564
-
Georg Ringer voted on patch set 21 V +1 CR +1 03/16/21, 07:22
-
Christian Kuhn commented on patch set 21 CR -1 03/16/21, 10:53
reviewing -
Christian Kuhn rebased onto patch set 22 03/16/21, 14:22
-
Christian Kuhn voted on patch set 22 CR -1 03/16/21, 14:22
-
TYPO3com voted on patch set 22 V -1 03/16/21, 14:29 Completed build in 07m 15s on Tue, 16 Mar, 02:29 PM Test Summary: 32124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10166
-
core-ci voted on patch set 22 V +1 03/16/21, 14:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1603
-
TYPO3com voted on patch set 22 V +1 03/16/21, 14:52 Completed build in 37m 54s on Tue, 16 Mar, 02:52 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10166
-
Christian Kuhn commented on patch set 22 03/16/21, 17:33
SiteTcaInline.php:218sure this is needed? doesn't TcaLanguage continue if type!=='language' anyways?TcaInline.php:291sure this is needed? doesn't TcaLanguage continue if type!=='language' anyways?DataHandler.php:1819definedTcaSystemLanguageCollector.php:65should have a comment that this is used for be_users and be_groups 'allowed_languages' fields. other than that it's ok to have this method here since the entire class is @internal and shouldn't be misused by extensions anyway.DefaultConfiguration.php:548please add a 'depends' to the previous data provider, 'TcaColumnsRemoveUnused' - this basically enforces that the dependencyResolver can't juggle this around, which can be pretty hard to debug if that happens: the top-down order here in this file should also be the default order that is calculated, so it's clear for extensions to be sure they can hook in at a specific point.Feature-57082-NewTCATypeLanguage.rst:28differentFeature-57082-NewTCATypeLanguage.rst:30maybe add a short paragraph that the new TCA type does not trigger sys_refindex entries for these 'relations' anymore: the cli command 'bin/typo3 referenceindex:update' should be executed to clean this up - it also makes that db table quite a bit smaller, which is a good thing, too.Feature-57082-NewTCATypeLanguage.rst:87this "Just as" sentence is misleading: be_users and be_groups are a different (internal) use case. Let's drop that sentence altogether.Feature-57082-NewTCATypeLanguage.rst:90That's not an upgrade wizard: Let's phrase it like this: "An automatic TCA migration is performed on the fly, adding deprecation messages ... bla"Feature-57082-NewTCATypeLanguage.rst:97until ... and maybe a bit too much information. maybe just drop the entire paragraph?locallang_general.xlf:178I always found the phrase 'Special languages' confusing. Do we have something better, where exactly is this used? If we don't have something better right now, we could keep it, though...importPagesAndRelatedTtContentWithImagesButNotIncluded.csv:23weird. what triggers this change? do you have any idea? did you dig deeper here? similar for other files below ... -
Oli Bartsch uploaded patch set 23 03/16/21, 20:18
-
Oli Bartsch commented on patch set 23 03/16/21, 20:20
SiteTcaInline.php:218ReplyDoneTcaInline.php:291ReplyDoneDataHandler.php:1819ReplyDoneTcaSystemLanguageCollector.php:65ReplyDoneDefaultConfiguration.php:548ReplyDoneFeature-57082-NewTCATypeLanguage.rst:28ReplyDoneFeature-57082-NewTCATypeLanguage.rst:30ReplyDoneFeature-57082-NewTCATypeLanguage.rst:87ReplyDoneFeature-57082-NewTCATypeLanguage.rst:90ReplyDoneFeature-57082-NewTCATypeLanguage.rst:97ReplyChanged to "until". Would like to leave this here. I'm in general a fan of providing such information, so people are aware, their configuration is not "lost" and there is no "bug", but they just have to adapt the necessary places. Otherwise this is always kind of "trial and error".locallang_general.xlf:178ReplyThis is used in the select element as optgroup label. All custom items (e.g. user defined via TSconfig) are added to this optgroup together with the "-1". I think the term does actually suits here really well, since these aren't "system defined (site) languages". I'm fully open for suggestions. Otherwise I would keep it as it is, for now.importPagesAndRelatedTtContentWithImagesButNotIncluded.csv:23ReplyAs discussed via slack, this has to be a bug in the test, since `width` and `height` are defined as `l10n_mode=exclude` and can therefore never change in a translation. Im not quite sure why this did not fail previously. Similar test fixtures of EXT:impexp do use the correct values already, see e.g. importPagesAndRelatedTtContentWithDifferentImageToExistingData.csv -
TYPO3com voted on patch set 23 V +1 03/16/21, 20:27 Completed build in 08m 17s on Tue, 16 Mar, 08:27 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10172
-
core-ci voted on patch set 23 V +1 03/16/21, 20:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1612
-
Oli Bartsch updated the commit message in patch set 24 03/16/21, 20:39
-
TYPO3com voted on patch set 24 V +1 03/16/21, 20:46 Completed build in 07m 26s on Tue, 16 Mar, 08:46 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10173
-
core-ci voted on patch set 24 V +1 03/16/21, 20:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1613
-
Georg Ringer voted on patch set 24 V +1 CR +1 03/16/21, 21:10
-
Benni Mack voted on patch set 24 V +1 CR +1 03/16/21, 21:25
-
Christian Kuhn voted on patch set 24 CR -1 03/16/21, 21:29
-
Christian Kuhn commented on patch set 24 03/16/21, 21:36
Feature-57082-NewTCATypeLanguage.rst:97Replyok.locallang_general.xlf:178Replyok.importPagesAndRelatedTtContentWithImagesButNotIncluded.csv:23Replyyeah ... bit of a mystery, but 'more correct' now ... we'll see. -
Christian Kuhn voted on patch set 24 V +2 CR +2 03/16/21, 21:38
-
Christian Kuhn merged patch set 25 03/16/21, 21:39