60297[BUGFIX] Fix behaviour of useDefaultLanguageRecord
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1827
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V -1 03/19/19, 09:39 Completed build in 11m 14s on Tue, 19 Mar, 10:39 AM Test Summary: 2 of 47606 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32847
-
TYPO3com voted on patch set 2 V -1 03/19/19, 09:45 Completed build in 15m 15s on Tue, 19 Mar, 10:45 AM Test Summary: 1 of 47606 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32848
-
TYPO3com voted on patch set 2 V +1 03/19/19, 18:15 Completed build in 9h 00m 37s on Tue, 19 Mar, 07:15 PM Test Summary: 47213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32848
-
Benni Mack commented on patch set 2 03/22/19, 21:34
-
Jonas Eberle commented on patch set 2 07/04/19, 18:00
should we change that everywhere in that file? l10n = lOCALIZATIOn i18n = iNTERNATIONALIZATIOn -
Oliver Eglseder commented on patch set 2 07/05/19, 09:14
EditDocumentController.php:872Reply UnresolvedWell... i just copied the code. Changing variables names should be another task, especially because "l18n" is used throughout the core. If you really require this to be changed for the PR to pass i will fix it of course. -
Jonas Eberle commented on patch set 2 07/16/19, 19:52
Rather fix it than leave it the (wrong) way. I think that would be Benni's intention, too. -
Oliver Klee commented on patch set 2 07/16/19, 21:06
EditDocumentControllerTest.php:50Unresolved: arrayEditDocumentControllerTest.php:76Unresolved: void -
Susi Moog commented on patch set 3 10/25/19, 21:32
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 10/25/19, 21:32 Completed build in 14s on Fri, 25 Oct, 09:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37749
-
TYPO3com commented on patch set 3 01/19/20, 11:44 Completed build in 17s on Sun, 19 Jan, 11:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40084
-
TYPO3com commented on patch set 3 02/23/20, 21:28 Completed build in 30s on Sun, 23 Feb, 09:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-587
-
Daniel Goerz commented on patch set 4 02/23/20, 21:41
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V -1 02/23/20, 21:45 Completed build in 13s on Sun, 23 Feb, 09:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-590
-
Susi Moog uploaded patch set 5 02/28/20, 07:00
-
Susi Moog commented on patch set 5 02/28/20, 07:01
resolved merge conflicts -
Susi Moog voted on patch set 5 V +1 CR +1 02/28/20, 07:01
-
TYPO3com voted on patch set 5 V +1 02/28/20, 07:11 Completed build in 10m 53s on Fri, 28 Feb, 07:11 AM Test Summary: 72021 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-764
-
Helmut Hummel commented on patch set 5 V -1 02/28/20, 13:44
EditDocumentController.php:897this condition does not make sense to me. like that $recordArray[$l10nPointer] is always returned when useDefaultLanguageRecord is set to 1, even when the table has no transOrigPointerField configured, or the record is a default language record. braces need to be added around the or condition or the or condition must be replaced with `$previewConfiguration['useDefaultLanguageRecord'] ?? true`EditDocumentControllerTest.php:166please add test cases for non translatable tables and default language records -
Susi Moog uploaded patch set 6 02/28/20, 16:01
-
Susi Moog commented on patch set 6 02/28/20, 16:01
EditDocumentController.php:897Reply Unresolveddone.EditDocumentControllerTest.php:166ReplyDone -
TYPO3com voted on patch set 6 V +1 02/28/20, 16:14 Completed build in 13m 01s on Fri, 28 Feb, 04:14 PM Test Summary: 72087 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-799
-
Susi Moog voted on patch set 6 V +1 CR +1 02/29/20, 19:01
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 03/21/20, 08:27
-
Anja Leichsenring merged patch set 7 03/21/20, 08:27
EditDocumentController.php:872