Review main Merged

60300[BUGFIX] Mark input fields edited by datepicker as changed

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 03/22/19, 11:52

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Daniel Goerz uploaded patch set 1 03/20/19, 15:43

  2. Daniel Goerz updated the commit message in patch set 2 03/20/19, 15:44

  3. TYPO3com voted on patch set 1 V -1 03/20/19, 15:59 Completed build in 15m 50s on Wed, 20 Mar, 04:59 PM Test Summary: 1 of 47594 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32865

  4. TYPO3com voted on patch set 2 V +1 03/20/19, 16:00 Completed build in 16m 05s on Wed, 20 Mar, 05:00 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32866

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 03/22/19, 10:07

  6. Markus Klein commented on patch set 2 03/22/19, 11:38

    If I edit a field by setting a date and then remove the date again, it is still marked as modified. Intended?
  7. Andreas Kienast commented on patch set 2 03/22/19, 11:46

    > Patch Set 2: > > If I edit a field by setting a date and then remove the date again, it is still marked as modified. Intended? That a general issue within FormEngine.
  8. Georg Ringer voted on patch set 2 V +2 CR +2 03/22/19, 11:52

  9. Georg Ringer merged patch set 3 03/22/19, 11:52