Review main Merged

60302[TASK] Add be_user id to LinkGenerator page-version test context

Benjamin Franzke CR +2 V +2 Easy +29 −18 updated 03/25/19, 10:20

Commit message

Some of the previous todos were failing because the test context
contained a workspace id, but missed a backend user id.
In that case the workspace id was ignored by the test
framework (see TYPO3\JsonResponse\Middleware\BackendUserMiddleware).

This patch also adapts the SlugLinkGeneratorTest to check link
generation to versioned record both with and without a backend user
authentication.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 03/21/19, 08:21

  2. TYPO3com voted on patch set 1 V +1 03/21/19, 08:38 Completed build in 17m 03s on Thu, 21 Mar, 09:38 AM Test Summary: 47237 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32872

  3. Benni Mack voted on patch set 1 V +1 CR +1 03/22/19, 21:22

  4. Oliver Hader wrote 03/25/19, 08:22

    Topic set to workspaces
  5. Oliver Hader uploaded patch set 2 03/25/19, 08:52

  6. Oliver Hader commented on patch set 2 V +1 CR +1 03/25/19, 08:53

    Just had some tiny adjustments... good to be merged, when Bamboo has finished
  7. TYPO3com voted on patch set 2 V +1 03/25/19, 09:06 Completed build in 13m 55s on Mon, 25 Mar, 10:06 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32938

  8. Daniel Goerz updated the commit message in patch set 3 03/25/19, 09:18

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 03/25/19, 09:18

  10. TYPO3com voted on patch set 3 V -1 03/25/19, 09:33 Completed build in 14m 48s on Mon, 25 Mar, 10:33 AM Test Summary: 47186 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32942

  11. Daniel Goerz commented on patch set 3 03/25/19, 09:41

    getting a lot of random bamboo failures lately ...
  12. TYPO3com voted on patch set 3 V +1 03/25/19, 10:00 Completed build in 57m 28s on Mon, 25 Mar, 11:00 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32942

  13. Oliver Hader voted on patch set 3 V +2 CR +2 03/25/19, 10:19

  14. Oliver Hader merged patch set 4 03/25/19, 10:20