Review main Merged

60305[BUGFIX] DB check > Search: Convert `--div--` to optgroup

Andreas Kienast CR +2 V +2 Easy +11 −1 updated 03/26/19, 14:36

Commit message

Querying the database for the placeholder `--div--` is rather pointless,
thus this possibility is removed. Instead, the placeholder is converted
into an optgroup.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Henrik Elsner +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Henrik Elsner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Andreas Kienast uploaded patch set 1 03/21/19, 16:26

  2. Andreas Kienast updated the commit message in patch set 2 03/21/19, 16:27

  3. TYPO3com voted on patch set 1 V +1 03/21/19, 16:45 Completed build in 18m 27s on Thu, 21 Mar, 05:45 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32876

  4. TYPO3com voted on patch set 2 V -1 03/21/19, 16:49 Completed build in 17m 58s on Thu, 21 Mar, 05:49 PM Test Summary: 1 of 47594 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32877

  5. TYPO3com voted on patch set 2 V +1 03/22/19, 07:42 Completed build in 15h 28m 35s on Fri, 22 Mar, 08:42 AM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32877

  6. Daniel Goerz commented on patch set 2 03/25/19, 15:07

    QueryGenerator.php:778

    Cant we reduce the whole patch to if (!$optGroupOpen && $val[1] === '--div--') { $out[] = '<optgroup label="' . htmlspecialchars($value) . '"></optgroup>'; } ?
  7. Daniel Goerz commented on patch set 2 03/25/19, 15:08

    QueryGenerator.php:778 Reply

    Sorry, I meant if ($val[1] === '--div--') { $out[] = '<optgroup label="' . htmlspecialchars($value) . '"></optgroup>'; }
  8. Daniel Goerz commented on patch set 2 03/25/19, 15:11

    Ah, the options need to be inside the optgroup, right? :)
  9. Daniel Goerz uploaded patch set 3 03/25/19, 15:14

  10. Daniel Goerz voted on patch set 3 V +1 CR +1 03/25/19, 15:19

  11. TYPO3com voted on patch set 3 V +1 03/25/19, 15:39 Completed build in 24m 41s on Mon, 25 Mar, 04:39 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32956

  12. Henrik Elsner voted on patch set 3 V +1 CR +1 03/26/19, 13:53

  13. Georg Ringer voted on patch set 3 V +2 CR +2 03/26/19, 14:36

  14. Georg Ringer merged patch set 4 03/26/19, 14:36