60309[BUGFIX] Preprocess MM relations of inline columns
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2432
Show 57 earlier messages
-
Cyril Janody uploaded patch set 1 03/22/19, 14:41
-
Fabien Udriot voted on patch set 1 CR +1 03/22/19, 14:51
-
TYPO3com voted on patch set 1 V +1 03/22/19, 14:56 Completed build in 14m 19s on Fri, 22 Mar, 03:56 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32885
-
Frédéric Lebel voted on patch set 1 V +1 CR +1 03/22/19, 15:09
-
Stephan Großberndt updated the commit message in patch set 2 03/22/19, 20:36
-
TYPO3com voted on patch set 2 V +1 03/22/19, 20:54 Completed build in 18m 06s on Fri, 22 Mar, 09:54 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32890
-
Frédéric Lebel voted on patch set 2 V +1 CR +1 03/25/19, 18:20
-
Fabien Udriot voted on patch set 2 CR +1 03/25/19, 19:03
-
Cyril Janody voted on patch set 2 V +1 CR +1 03/25/19, 19:13
-
Stephan Großberndt commented on patch set 2 03/25/19, 20:14
I think it would be a good idea to back this change by tests in order to avoid issues. -
Cyril Janody rebased onto patch set 3 03/26/19, 20:25
-
TYPO3com voted on patch set 3 V +1 03/26/19, 20:37 Completed build in 12m 14s on Tue, 26 Mar, 09:37 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32978
-
Cyril Janody voted on patch set 3 V +1 03/27/19, 13:01
-
Cyril Janody voted on patch set 3 CR +1 03/27/19, 13:01
-
Stephan Großberndt commented on patch set 3 CR -1 03/27/19, 13:38
I think it would be a good idea to back this change by DataHandler tests in order to avoid issues. -
Cyril Janody commented on patch set 3 03/27/19, 14:47
> Patch Set 3: Code-Review-1 > > I think it would be a good idea to back this change by DataHandler tests in order to avoid issues. Excellent idea but it involves much more than just adding tests. I do not think to be the right person to test all the «implications» -
Benni Mack updated the commit message in patch set 4 05/25/20, 18:40
-
TYPO3com voted on patch set 4 V +1 05/25/20, 18:53 Completed build in 13m 05s on Mon, 25 May, 06:53 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3521
-
Oliver Hader commented on patch set 4 06/14/21, 11:50
Some tests would be great here... Spoiler: Currently, there are only tests for `IRRE/CSV` and `IRRE/ForeignField` - none yet for `IRRE/MM`...DataHandler.php:8155To complete it, there should be a check for `foreign_table` as well... -
Christian Kuhn commented on patch set 4 09/20/21, 14:59
There are more issues with inline-mm and there is currently zero DH functional test coverage. We'll have to spend quite a bit of dedicated time on this to get this right. -
Benni Mack uploaded patch set 5 11/11/21, 08:28
-
Benni Mack commented on patch set 5 11/11/21, 08:28
DataHandler.php:8155ReplyDone -
core-ci voted on patch set 5 V -1 11/11/21, 08:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19166
-
Oliver Hader commented on patch set 5 CR -1 11/11/21, 09:02
Syntax error -
Benni Mack updated the commit message in patch set 6 11/18/21, 10:46
-
Benni Mack uploaded patch set 7 11/18/21, 11:27
-
core-ci voted on patch set 6 V -1 11/18/21, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19470
-
core-ci voted on patch set 7 V -1 11/18/21, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19502
-
core-ci voted on patch set 7 V +1 11/24/21, 23:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19502
-
Christian Kuhn commented on patch set 7 CR -1 11/25/21, 00:45
will look at this. -
Christian Kuhn commented on patch set 7 11/25/21, 13:00
Hey. Thanks for the patch. Let us have a decision on it for now: I can confirm inline-mm has issues. Clicking around on tx_styleguide_inline_mm easily shows this. I think it's the scenario you're talking about: A parent-child relation with a "true" mm table in between (the mm table has no TCA). I think it's pretty much undefined on what should actually happen with this scenario at all. We *could* simply merge that patch and hope for the best, but this is not a sustainable solution. To really get this done, some serious coverage needs to be created: A test extension plus tests (probably similar to the "group ManyToMany" scenarios) for core and workspaces, and probably also some acceptance test to click around on it a bit. I'm sure we'll run into various further issues (both in DataHandler and in FormEngine) when really looking at inline-mm, and I'd estimate at least about a week of work to really have progress. I currently have no time to take care of this: inline-true-mm is a very seldom use case and even though we fixed a lot of group-mm recently (categories use this), inline-true-mm is still quite different again. We probably won't have progress from other contributors at the moment either. Thus, I'll go ahead and will abandon the patch for now, keeping the issue open. If anyone wants to spend time on this, please contact me, we can for sure have a more detailed look on what has to be done to proceed. I hope this is ok with you. -
Christian Kuhn abandoned the change 11/25/21, 13:02