Review main Merged

60310[TASK] Allow TCA display conditions with only one element for AND/OR

Markus Klein CR +2 V +2 Normal +22 −30 updated 03/23/19, 19:59

Commit message

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Markus Klein uploaded patch set 1 03/22/19, 14:58

  2. Markus Klein uploaded patch set 2 03/22/19, 14:59

  3. TYPO3com voted on patch set 2 V +1 03/22/19, 15:12 Completed build in 12m 21s on Fri, 22 Mar, 04:12 PM Test Summary: 47213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32887

  4. TYPO3com voted on patch set 1 V +1 03/22/19, 15:13 Completed build in 15m 22s on Fri, 22 Mar, 04:13 PM Test Summary: 47213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32886

  5. Markus Klein updated the commit message in patch set 3 03/22/19, 22:08

  6. Markus Klein wrote 03/22/19, 22:09

    Description "Edit commit message" removed
  7. Markus Klein commented on patch set 3 03/22/19, 22:10

    This change is ready for review.
  8. TYPO3com voted on patch set 3 V +1 03/22/19, 22:24 Completed build in 16m 00s on Fri, 22 Mar, 11:24 PM Test Summary: 47213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32894

  9. Stephan Großberndt voted on patch set 3 CR +1 03/23/19, 08:25

  10. Josef Glatz commented on patch set 3 CR +1 03/23/19, 10:15

    I see the benefit from it. I would rather suggest to add a breaking rst: What if someone relies on that for any custom layer on top of TCA layer? (All in all: do not look so critical)
  11. Josef Glatz voted on patch set 3 V +1 03/23/19, 10:33

  12. Stephan Großberndt commented on patch set 3 03/23/19, 11:51

    I do not consider it breaking, the conditions are evaluated like before the patch, you just gain more flexibility for conditions in new TCA definitions. But would not recommend to backport anyway as an extension would need to require TYPO3 >9.5.5 if using such a condition in TCA.
  13. Josef Glatz commented on patch set 3 03/23/19, 12:46

    > Patch Set 3: > > I do not consider it breaking, the conditions are evaluated like before the patch, you just gain more flexibility for conditions in new TCA definitions. > But would not recommend to backport anyway as an extension would need to require TYPO3 >9.5.5 if using such a condition in TCA. Absolutely fine with that!
  14. Georg Ringer voted on patch set 3 V +2 CR +2 03/23/19, 19:59

  15. Georg Ringer merged patch set 4 03/23/19, 19:59