60311[BUGFIX] Deliver detected file type for IM identify
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Sebastian Rosskopf +1
- Jochen Roth +1
- Markus Klein +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Sebastian Rosskopf +1
- Jochen Roth +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2430
Show 45 earlier messages
-
Benni Mack uploaded patch set 1 03/22/19, 19:29
-
Georg Ringer voted on patch set 1 CR +1 03/22/19, 19:35
-
TYPO3com voted on patch set 1 V +1 03/22/19, 19:39 Completed build in 10m 18s on Fri, 22 Mar, 08:39 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32888
-
Alexander Schnitzler commented on patch set 1 V -1 CR +1 03/23/19, 08:40
I can't really verify this due to the fact that processor_allowFrameSelection is set to true by default in DefaultConfiguration.php and the identify command then fails on my local instance. Could you shed some light on it? Like, if this is a local issue of mine or if this could be a general issue? -
Benni Mack uploaded patch set 2 03/23/19, 20:45
-
Benni Mack commented on patch set 2 03/23/19, 20:47
Nice one, Alex. This actually was still a bug from when the $frame concept and shellArguments was added. I also enabled the option on my machine and it did not work anymore :) So this is fixed. I wonder where I could proper tests for IM exec commands... -
TYPO3com voted on patch set 2 V +1 03/23/19, 20:57 Completed build in 11m 50s on Sat, 23 Mar, 09:57 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32907
-
Alexander Schnitzler commented on patch set 2 03/23/19, 21:02
> So this is fixed. I wonder where I could proper tests for IM exec commands... I wondered myself how to test this in a unit test. Locally it's not a problem but it would be great to have an option to test this stuff with Bamboo. I will test this patch again tomorrow evening and put my votes. -
Benni Mack uploaded patch set 3 03/23/19, 21:03
-
TYPO3com voted on patch set 3 V +1 03/23/19, 21:21 Completed build in 18m 30s on Sat, 23 Mar, 10:21 PM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32909
-
Alexander Schnitzler commented on patch set 3 03/23/19, 22:01
GraphicalFunctionsTest.php:116I am sorry to say but I dislike these kind of tests where you mock an object, tell it what to do and then test if it does what you told it to do. It's really just a test if phpunit does its job right. Well, this one actually tests a few lines of code but it's the kind of unit test that should be a functional test. No -1 from me but I'd be glad to avoid these tests in the future. -
Benni Mack commented on patch set 3 03/23/19, 22:07
GraphicalFunctionsTest.php:116Reply Unresolvedyeah, I know. This actually tests NOT the IM call (that needs to be a functional ofc) but the array splitting. -
Alexander Schnitzler commented on patch set 3 V +1 CR +1 03/23/19, 22:17
Alright, latest patch set works just fine. -
Daniel Goerz commented on patch set 3 V -1 03/24/19, 11:02
As I tested this locally I saw that this would slightly change the output (at least on my machine). Prior to the path the Height attribute included the page offset (+0+0) in the returned array. So for example for an image which is 400px in height the method returns * prior to patch: '400+0+0' (string) * with patch applied: 400 (integer) The page offset can be added to the formatted output of identify by using %O. So, we have some options here: 1) Add it to the height again and don't cast to integer, to keep the output the same 2) Add the page offset as an additional array item in the returned array to still ptovide the information 3) Go with PS3 and drop the offset information from the height and the returned array entirely and say its an improvement. I am using GM locally, so I don't know if IM behaves differently here. I am fine with changing the output here since it makes more sense to only return the height. However this would be breaking if anybody was using the offset information. Don't know how likely that is, though... -
Benni Mack commented on patch set 3 03/24/19, 11:05
Hi Daniel, good point, It wasn't cast before... so it shouldn't do it now (was misreading the existing logic!) -
Daniel Goerz commented on patch set 3 03/24/19, 18:14
> Hi Daniel, > > good point, It wasn't cast before... so it shouldn't do it now (was > misreading the existing logic!) So, are you in favor of adding the offset to the formatted output via %O and append it to the height as it was before? I'd rather streamline this, add the offset as an additional array item and mark the patch as breaking (or at least add an important RST) -
Benni Mack uploaded patch set 4 03/26/19, 05:15
-
Benni Mack commented on patch set 4 03/26/19, 05:16
I double-checked the (only) usage of getting width/height in the ImageInfo PHP right now. This seems very odd to me that there is actually (int) expected... I'm fine with making it either way (can't really decide). -
TYPO3com voted on patch set 4 V +1 03/26/19, 05:25 Completed build in 10m 49s on Tue, 26 Mar, 06:25 AM Test Summary: 47265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32966
-
Markus Klein updated the commit message in patch set 5 04/05/19, 10:41
-
Markus Klein commented on patch set 5 04/05/19, 10:44
GraphicalFunctions.php:2415Unresolvedempty is not needed anymore if we cast to an int anyways. if the variables are not set for some reason, then the cast will already trigger the php warning -
TYPO3com voted on patch set 5 V +1 04/05/19, 11:14 Completed build in 24m 05s on Fri, 5 Apr, 01:14 PM Test Summary: 47265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33058
-
Sebastian Rosskopf voted on patch set 5 V +1 CR +1 04/05/19, 11:36
-
Benni Mack commented on patch set 6 04/05/19, 11:39
Published edit on patch set 5. -
Sebastian Rosskopf voted on patch set 6 V +1 CR +1 04/05/19, 11:57
-
Markus Klein voted on patch set 6 CR +1 04/05/19, 11:59
-
Jochen Roth voted on patch set 6 V +1 CR +1 04/05/19, 12:00
-
TYPO3com voted on patch set 6 V +1 04/05/19, 12:06 Completed build in 26m 13s on Fri, 5 Apr, 02:06 PM Test Summary: 47265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33062
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 04/05/19, 16:52
-
Anja Leichsenring merged patch set 7 04/05/19, 16:52