Review main Merged

60320[TASK] Remove leftover unused code in various PHP classes

Benni Mack CR +2 V +2 Normal +55 −121 updated 03/25/19, 19:31

Commit message

Due to removal of functionality and code in recent TYPO3 versions,
internal code can now be removed:

- PermissionAjaxController->getBackendUser()
- RteHtmlParser->TS_AtagToAbs (never called)
- PageRenderer->extOnReadyCode property
- SetupModuleController
  - used several properties from the now removed "simulateUser"
     code which is not part of this module anymore.
  - At the same time, various "init" and "main" methods which are now protected are
    reordered to reflect the set up request workflow better.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1216

  1. Benni Mack uploaded patch set 1 03/23/19, 21:50

  2. TYPO3com voted on patch set 1 V +1 03/23/19, 22:06 Completed build in 15m 30s on Sat, 23 Mar, 11:06 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32914

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/25/19, 06:32

  4. Andreas Kienast voted on patch set 1 CR +1 03/25/19, 08:10

  5. Daniel Goerz commented on patch set 1 03/25/19, 08:55

    SetupModuleController.php:181

    The method only accepts an array and can only process an array. So this should be reflected here by removing null and object. Passing null or an object will break.

    SetupModuleController.php:332

    We should make sure that $request->getParsedBody() is not an object here
  6. Daniel Goerz uploaded patch set 2 03/25/19, 09:05

  7. TYPO3com voted on patch set 2 V -1 03/25/19, 09:05 Completed build in 11s on Mon, 25 Mar, 10:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32940

  8. Daniel Goerz uploaded patch set 3 03/25/19, 09:06

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 03/25/19, 09:07

  10. TYPO3com voted on patch set 3 V -1 03/25/19, 09:18 Completed build in 11m 41s on Mon, 25 Mar, 10:18 AM Test Summary: 2 of 47614 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32941

  11. Daniel Goerz updated the commit message in patch set 4 03/25/19, 09:37

  12. Daniel Goerz voted on patch set 4 V +1 CR +1 03/25/19, 09:38

  13. TYPO3com voted on patch set 4 V +1 03/25/19, 09:51 Completed build in 13m 41s on Mon, 25 Mar, 10:51 AM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32943

  14. Georg Ringer voted on patch set 4 V +2 CR +2 03/25/19, 14:23

  15. Benni Mack voted on patch set 4 V +2 CR +2 03/25/19, 19:31

  16. Benni Mack merged patch set 5 03/25/19, 19:31