60324[BUGFIX] RTE: Support anchors without `href`
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Guido Schmechel +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 2736
Show 811 earlier messages
-
Thorben Nissen uploaded patch set 1 03/24/19, 16:07
-
Benni Mack commented on patch set 1 03/24/19, 16:10
Thanks Torben. Also, the patch should go into 9.5 as well. I think it should be OK if we could add tests for these cases (RteHtmlParser has some already). About the ContentObjectRenderer change, I have to think about it. Basically, you're suggesting that `<a name="benni">blabla</a>` should be allowed, right? -
Thorben Nissen commented on patch set 1 03/24/19, 16:14
@benni The change should go into 9 and 8 probably. But the patch must look a bit different due to the changes made in 10. I will provide a separate patch for that. Actually the content object renderer it one of the important parts, as the `<a>` without the `href` would not be rendered. But I'm open to are more elegant solution. -
TYPO3com voted on patch set 1 V +1 03/24/19, 16:21 Completed build in 14m 05s on Sun, 24 Mar, 05:21 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32925
-
Thorben Nissen uploaded patch set 2 03/24/19, 17:08
-
Thorben Nissen updated the commit message in patch set 3 03/24/19, 17:09
-
Thorben Nissen commented on patch set 2 03/24/19, 17:10
@benni I added unit tests. It looks like, the change can be applied to CMS 9 and 8 too. -
TYPO3com voted on patch set 2 V +1 03/24/19, 17:24 Completed build in 16m 18s on Sun, 24 Mar, 06:24 PM Test Summary: 47249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32926
-
TYPO3com voted on patch set 3 V +1 03/24/19, 17:25 Completed build in 15m 26s on Sun, 24 Mar, 06:25 PM Test Summary: 47249 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32927
-
Riccardo De Contardi commented on patch set 3 V +1 03/24/19, 20:19
tested with Master and "full" config of CKEditor, seems to work both with empty anchors and with anchors that have text inside. -
Jörg Bösche commented on patch set 3 CR -1 04/08/19, 13:39
ContentObjectRenderer.php:4999Extract the new code to a method. E.g. "resolveAnchorLink()"ContentObjectRenderer.php:5000Can be moved inside of the condition. A variable $anchorTag is not needed.
-
Susi Moog commented on patch set 3 10/25/19, 19:50
Jörgi, can you maybe make the code changes you requested? Merci! -
Jörg Bösche uploaded patch set 4 10/28/19, 07:45
-
Jörg Bösche commented on patch set 4 10/28/19, 07:46
Resolved the merge conflict and extracted the new part into a method. Could not elimnate the variable assignment ($anchorTag), because of available hook in ($this->getATagParams()-> getATagParamsPostProc). -
TYPO3com voted on patch set 4 V +1 10/28/19, 07:55 Completed build in 09m 45s on Mon, 28 Oct, 07:55 AM Test Summary: 48099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37815
-
Jörg Bösche uploaded patch set 5 10/28/19, 07:57
-
Susi Moog commented on patch set 5 CR +1 10/28/19, 08:01
thx. -
TYPO3com voted on patch set 5 V -1 10/28/19, 08:07 Completed build in 09m 37s on Mon, 28 Oct, 08:07 AM Test Summary: 1 of 47895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37816
-
TYPO3com commented on patch set 5 10/28/19, 08:20 Completed build in 10m 58s on Mon, 28 Oct, 08:20 AM Test Summary: 47869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37817
-
TYPO3com voted on patch set 5 V +1 10/28/19, 15:19 Completed build in 7h 21m 31s on Mon, 28 Oct, 03:19 PM Test Summary: 48099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37817
-
Susi Moog commented on patch set 5 10/28/19, 18:47
Can you add some description on how to insert the mentioned CKEditor anchor tags? Do I need a plugin for that? -
Riccardo De Contardi commented on patch set 5 10/28/19, 21:24
> Patch Set 5: > > Can you add some description on how to insert the mentioned CKEditor anchor tags? Do I need a plugin for that? No plugin needed; just use the full preset; use the "flag" icon near to the "link" and "remove link" icons -
Susi Moog voted on patch set 5 V +1 11/09/19, 09:41
-
Susi Moog commented on patch set 5 11/09/19, 09:41
> Patch Set 5: > > > Patch Set 5: > > > > Can you add some description on how to insert the mentioned CKEditor anchor tags? Do I need a plugin for that? > > No plugin needed; just use the full preset; use the "flag" icon near to the "link" and "remove link" icons ah, thanks :) -
Guido Schmechel voted on patch set 5 V +1 CR +1 11/09/19, 10:08
-
Riccardo De Contardi voted on patch set 5 V +1 11/09/19, 10:22
-
Benni Mack commented on patch set 5 11/09/19, 11:22
RteHtmlParser.php:757Unresolvedit does not set "rtekeep". Also this method is not in use.RteHtmlParser.php:793Unresolvedthis method is never used, why adding it? -
Susi Moog voted on patch set 5 CR -1 11/09/19, 11:24
-
Susi Moog uploaded patch set 6 11/09/19, 11:32
-
TYPO3com voted on patch set 6 V -1 11/09/19, 11:48 Completed build in 14m 12s on Sat, 9 Nov, 11:48 AM Test Summary: 9 of 48569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38155
-
TYPO3com voted on patch set 6 V +1 11/09/19, 12:49 Completed build in 1h 29m 50s on Sat, 9 Nov, 12:49 PM Test Summary: 48210 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38155
-
Susi Moog voted on patch set 6 V +1 CR +1 11/09/19, 12:57
-
Guido Schmechel voted on patch set 6 V +1 CR +1 11/09/19, 13:25
-
Benni Mack voted on patch set 6 V +2 CR +2 11/09/19, 13:39
-
Benni Mack merged patch set 7 11/09/19, 13:39
-
Susi Moog commented on patch set 7 11/17/19, 16:36
This introduced a regression, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/62336