Review main Merged

60325[BUGFIX] Fix serialization of loggers

Helmut Hummel CR +2 V +2 Easy +24 −19 updated 04/16/19, 11:39

Commit message

Only dealing with PHP file resource in writers is not
enough to properly initialize a logger on wakeup.

A logger has to log with a new request IDs and possibly completely new writers
and processors due to configuration changes in the meantime.

Therefore the __sleep and __wakeup methods are removed in the FileWriter
and new methods are added to the logger instance to make sure a
wakeup will have a correctly configured logger instance.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Ralf Merz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Ralf Merz +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 57

  1. Helmut Hummel uploaded patch set 1 03/25/19, 08:06

  2. TYPO3com voted on patch set 1 V -1 03/25/19, 08:20 Completed build in 14m 26s on Mon, 25 Mar, 09:20 AM Test Summary: 2 of 47610 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32935

  3. Ralf Merz commented on patch set 1 V +1 CR +1 03/25/19, 09:01

    Works on v9. I can now open Scheduler tasks again that have a "wrong" path to log file after e.g. deploying or copying a DB to another instance.
  4. TYPO3com voted on patch set 1 V +1 04/14/19, 15:37 Completed build in 7h 45m 21s on Sun, 14 Apr, 05:37 PM Test Summary: 47217 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32935

  5. Susi Moog voted on patch set 1 V +2 CR +2 04/14/19, 15:57

  6. Susi Moog merged patch set 2 04/14/19, 15:57

  7. Helmut Hummel commented on patch set 2 04/16/19, 11:39

    Thanks for the merge!