60326[BUGFIX] Fix fetching page overlays with disabled group check
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2225
-
Helmut Hummel uploaded patch set 1 03/25/19, 08:58
-
TYPO3com voted on patch set 1 V +1 03/25/19, 09:11 Completed build in 12m 44s on Mon, 25 Mar, 10:11 AM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32939
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/25/19, 09:49
-
Benni Mack commented on patch set 1 03/26/19, 07:47
Does it even make sense to fetch fe_group restriction on translated pages? -
Daniel Goerz commented on patch set 1 03/26/19, 09:21
Can you check if https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/59927/ solves this as well? If I see it correctly it tries to fix the same issue plus the broken preview for starttime/endtime restrictions of translated pages -
Helmut Hummel commented on patch set 1 04/15/19, 18:00
@Benni: you mean whether applying the group restriction makes sense when fetching overlay records? -
Helmut Hummel commented on patch set 1 04/15/19, 18:01
@Daniel: One symptom (wrong URLs generated) is fixed, but the cause (using the API with not respecting group restrictions) is not fixed in the other change request. -
Daniel Goerz voted on patch set 1 CR +1 07/02/19, 18:11
-
Steffen Frese voted on patch set 1 CR +1 07/08/19, 14:07
-
Oliver Klee commented on patch set 1 07/08/19, 14:11
PageRepository.php:362UnresolvedCan we please have type declarations for the new parameters? -
Mathias Schreiber commented on patch set 1 07/09/19, 07:31
took the liberty to fix the typo in the commit tag -
Julian Geils voted on patch set 1 CR +1 07/12/19, 12:42
-
Benni Mack updated the commit message in patch set 2 07/12/19, 12:52
-
TYPO3com voted on patch set 2 V +1 07/12/19, 13:16 Completed build in 13m 38s on Fri, 12 Jul, 03:16 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34967
-
Benni Mack voted on patch set 2 V +1 CR +1 07/13/19, 16:56
-
Daniel Goerz commented on patch set 2 V -1 CR -1 07/13/19, 18:54
PageRepository.php:310$disableGroupAccessCheck is never defined int this method (getPage_noCheck()). It is however in getPage()... so is this some kind of copy and/or paste error? -
Daniel Goerz commented on patch set 2 07/13/19, 19:58
Sorry, cant get this patch to work on master right now. Maybe related to other recent changes. -
Benni Mack commented on patch set 2 07/14/19, 08:56
Daniel, you're right! I've had another look again, and wanted to try out more with just using the API (PHP calls) directly. e.g. calling getPage_noCheck() always does overlays, but shouldn't do any other checks at all (not just excluding fe_group restrictions), the patch would actually open up one more possibility. How about we introduce a setter method for this use case then? This could also replace the $where_groupAccess logic that is built-in. Ideally (API wise), this information would be taken from the PageRepository->context information, but that wouldn't work for 9.5 anymore IMHO, I'd say (had some chats with Manuel already). -
Helmut Hummel commented on patch set 2 08/30/19, 13:27
> Patch Set 2: Verified-1 Code-Review-1 > > (1 comment)PageRepository.php:310Replyyes, good catch. C&P mistake -
Helmut Hummel uploaded patch set 3 08/30/19, 13:31
-
Helmut Hummel commented on patch set 3 08/30/19, 13:31
PageRepository.php:310ReplyDone -
TYPO3com voted on patch set 3 V -1 08/30/19, 13:40 Completed build in 09m 44s on Fri, 30 Aug, 01:40 PM Test Summary: 47001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35964
-
Susi Moog commented on patch set 3 CR -1 01/24/20, 15:02
the patch does not work for me (in fact, it confuses me as I can't quite figure out what it was meant to do) - however, I found the preview actually works in EditDocumentController, as that one is simply using the translated uid instead of the original page uid which then "just works". -
Benni Mack commented on patch set 3 03/19/20, 12:34
This should be solved now with the change related to the "hidden/group" change merged yesterday in TYPO3 v9.5 - https://review.typo3.org/c/Packages/TYPO3.CMS/+/62936 Let me know if we still need this @helhum -
Benni Mack abandoned the change 05/06/20, 15:02
fixed with the other change https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963