Review 9.5 Merged

60328[TASK] Add be_user id to LinkGenerator page-version test context

Oliver Hader CR +2 V +2 Easy +29 −18 updated 03/25/19, 12:28

Commit message

Some of the previous todos were failing because the test context
contained a workspace id, but missed a backend user id.
In that case the workspace id was ignored by the test
framework (see TYPO3\JsonResponse\Middleware\BackendUserMiddleware).

This patch also adapts the SlugLinkGeneratorTest to check link
generation to versioned record both with and without a backend user
authentication.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Oliver Hader commented on patch set 1 03/25/19, 10:20

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/LinkGeneratorTest.php * typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php
  2. TYPO3com voted on patch set 1 V -1 03/25/19, 10:20 Completed build in 13s on Mon, 25 Mar, 11:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-415

  3. Oliver Hader wrote 03/25/19, 10:24

    Topic workspaces-9.5 removed
  4. Oliver Hader wrote 03/25/19, 10:24

    Topic set to workspaces
  5. Oliver Hader commented on patch set 1 03/25/19, 10:25

    This change is ready for review.
  6. TYPO3com commented on patch set 1 03/25/19, 10:26 Completed build in 06m 25s on Mon, 25 Mar, 11:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-415

  7. Oliver Hader commented on patch set 1 03/25/19, 10:27

    WTF is Gerrit doing here?!?
  8. Oliver Hader voted on patch set 1 CR -1 03/25/19, 10:27

  9. Oliver Hader uploaded patch set 2 03/25/19, 11:06

  10. TYPO3com voted on patch set 2 V +1 03/25/19, 11:19 Completed build in 12m 27s on Mon, 25 Mar, 12:19 PM Test Summary: 49968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-416

  11. Oliver Hader commented on patch set 2 V -1 03/25/19, 11:20

    I'm getting a bunch of "[1.5.1]: The value of the field "alias" has been changed from "acme-first" to "acme-first0" as it is required to be unique." warnings locally - Bamboo is not showing them... Something seems to be wrong here...
  12. Oliver Hader voted on patch set 2 V 0 03/25/19, 12:25

  13. Oliver Hader commented on patch set 2 03/25/19, 12:26

    Alright, was a local issue with some testing-framework left-overs...
  14. Oliver Hader voted on patch set 2 V +2 CR +2 03/25/19, 12:27

  15. Oliver Hader merged patch set 3 03/25/19, 12:28