60345[TASK] Unify spelling for TSconfig
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Georg Ringer +1
- Stefan Froemken +1
-
Verified V +2 Done
- Frank Nägler +2
- Georg Ringer +1
- Stefan Froemken +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Documentation/Changelog/7.6/Breaking-70055-OverrideNewContentElementWizardViaPageTSconfig.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/7.6/Important-70956-BehaviorOfPageTSConfigOptionsKeepItemsAddItemsAndRemoveItemsChanged.rst+1 −1
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+2 −2
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php3+3 −3
Review log 1315
-
Sybille Peters uploaded patch set 1 03/26/19, 21:03
-
Oliver Klee voted on patch set 1 CR +1 03/26/19, 21:07
-
TYPO3com voted on patch set 1 V -1 03/26/19, 21:22 Completed build in 18m 20s on Tue, 26 Mar, 10:22 PM Test Summary: 2 of 47650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32979
-
Sybille Peters rebased onto patch set 2 03/27/19, 08:21
-
TYPO3com voted on patch set 2 V +1 03/27/19, 08:36 Completed build in 15m 09s on Wed, 27 Mar, 09:36 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32981
-
Sybille Peters wrote 03/27/19, 09:12
Description set to "No change. Pushed new patch to initiate rerun of tests." -
Henrik Elsner commented on patch set 2 03/27/19, 09:37
IMHO we should change it consistent through all affected files. So not only change comments but the variables too. Also directories are affected e.g. in sysext- linkvalidator and backend . Those TSConfig folders are spelled different too.LinkAnalyzer.php:97If we change it at this point, shouldn't the variable itself also change to $tsconfig ? At least that would be the consistent way imho -
Sybille Peters commented on patch set 2 03/27/19, 09:58
I agree, it would probably make sense to change it everywhere. I am not sure about the tag in the Changelog yet: It currently uses TSConfig as well. Would have to check where else that has to be changed. One is https://forger.typo3.com/utility/rst Also, before I put in the extra work, can someone confirm that TSconfig is actually the preferred and correct spelling? -
Henrik Elsner commented on patch set 2 03/27/19, 10:03
> Patch Set 2: > > I agree, it would probably make sense to change it everywhere. I am not sure about the tag in the Changelog yet: It currently uses TSConfig as well. Would have to check where else that has to be changed. One is https://forger.typo3.com/utility/rst > > Also, before I put in the extra work, can someone confirm that TSconfig is actually the preferred and correct spelling? my personal choice would be to go with "TSConfig" as my understanding of camelcase is to mark "word-combinations" with that upperletter and "TypoScriptconfiguration" can nowhere be found. Only with that upper 'C' -
Oliver Klee commented on patch set 2 03/27/19, 10:43
> IMHO we should change it consistent through all affected files. I agree, and I think we can do this in multiple changesets (i.e., this shouldn't block this changeset). -
Sybille Peters commented on patch set 2 03/27/19, 12:03
On second thought: I am not even sure if it should be changed in the code. For coding, other rules may apply than for "plaintext". Additionally, I think it is good to use consistent spelling, but right now there are so many other things to do ... -
Stefan Froemken commented on patch set 2 V +1 CR +1 04/24/19, 07:10
LinkAnalyzer.php:97ReplyWe have in Core 61 matches of $TSconfig. As variables has to start lower cased we have changed that to $tsConfig with currently 94 matches in core. $tsconfig was not found in Core. So, I don't think that we will implement a third version into Core. -
Georg Ringer voted on patch set 2 V +1 CR +1 04/24/19, 10:59
-
Frank Nägler commented on patch set 2 V +2 CR +2 05/10/19, 14:48
LinkAnalyzer.php:97Reply Unresolvedthe variable naming is fine and correct, we should not change it. -
Frank Nägler merged patch set 3 05/10/19, 14:49