60349[FEATURE] Add TypoScript config to force rendering robots meta tag
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1421
-
Kevin Appelt uploaded patch set 1 03/28/19, 15:53
-
Richard Haeser commented on patch set 1 03/28/19, 16:03
Some small things. After this is merged, we should also create some documentation for https://docs.typo3.org/typo3cms/TyposcriptReference/Setup/Config/Index.html.Little typo: Add a TypoScriptMetaTagGenerator.php:25This use-statement is not needed when removing the IDE commentMetaTagGenerator.php:117We don't need IDE information in here.MetaTagGenerator.php:118Do we only assign the $GLOBALS['TSFE'] to a different variable to make sure line 119 is not too long? -
TYPO3com voted on patch set 1 V +1 03/28/19, 16:10 Completed build in 16m 49s on Thu, 28 Mar, 05:10 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32990
-
Kevin Appelt uploaded patch set 2 03/28/19, 16:13
-
Kevin Appelt commented on patch set 2 03/28/19, 16:17
Reply
DoneMetaTagGenerator.php:25ReplyDoneMetaTagGenerator.php:117ReplyDoneMetaTagGenerator.php:118ReplyIt was a copy from another place in core. I've simplified it with patchset 2. -
TYPO3com voted on patch set 2 V +1 03/28/19, 16:24 Completed build in 10m 29s on Thu, 28 Mar, 05:24 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32991
-
Kevin Appelt updated the commit message in patch set 3 03/28/19, 17:26
-
Kevin Appelt uploaded patch set 4 03/28/19, 17:41
-
TYPO3com voted on patch set 3 V +1 03/28/19, 17:42 Completed build in 15m 42s on Thu, 28 Mar, 06:42 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32992
-
TYPO3com voted on patch set 4 V +1 03/28/19, 17:51 Completed build in 09m 51s on Thu, 28 Mar, 06:51 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32993
-
Richard Haeser uploaded patch set 5 03/28/19, 19:13
-
Richard Haeser uploaded patch set 6 03/28/19, 19:28
-
TYPO3com voted on patch set 5 V +1 03/28/19, 19:29 Completed build in 15m 20s on Thu, 28 Mar, 08:29 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32995
-
Richard Haeser uploaded patch set 7 03/28/19, 19:30
-
Richard Haeser voted on patch set 7 V +1 CR +1 03/28/19, 19:30
-
TYPO3com voted on patch set 6 V +1 03/28/19, 19:39 Completed build in 10m 59s on Thu, 28 Mar, 08:39 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32996
-
TYPO3com voted on patch set 7 V -1 03/28/19, 19:49 Completed build in 19m 10s on Thu, 28 Mar, 08:49 PM Test Summary: 1 of 47650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32997
-
Julian Wundrak voted on patch set 7 CR +1 03/28/19, 20:20
-
Anja Leichsenring commented on patch set 7 CR -1 03/29/19, 08:38
this is a feature and therefore excluded from backport. Master only, please. -
Richard Haeser commented on patch set 7 V -1 03/29/19, 09:54
Please check the easier solution in forge. -
Kevin Appelt abandoned the change 03/29/19, 10:15
Can be solved by set "page.meta.robots = index,follow" in TypoScript Setup