Review main Merged

60350[BUGFIX] Populate href lang URI only if the link is available

Julian Wundrak CR +2 V +2 Easy +2 −2 updated 04/12/19, 18:33

Commit message

If there are e.g., records that have no translation, the
HrefLangGenerator outputs the site-base URL. Expected is that the entry
for this page is suppressed.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Julian Wundrak uploaded patch set 1 03/28/19, 20:11

  2. Julian Wundrak updated the commit message in patch set 2 03/28/19, 20:12

  3. TYPO3com voted on patch set 1 V +1 03/28/19, 20:24 Completed build in 12m 03s on Thu, 28 Mar, 09:24 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33001

  4. TYPO3com voted on patch set 2 V +1 03/28/19, 20:28 Completed build in 15m 30s on Thu, 28 Mar, 09:28 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33002

  5. Oliver Klee updated the commit message in patch set 3 03/28/19, 21:42

  6. TYPO3com voted on patch set 3 V +1 03/28/19, 21:57 Completed build in 15m 30s on Thu, 28 Mar, 10:57 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33004

  7. Jörg Bösche commented on patch set 3 CR -1 04/08/19, 10:59

    HrefLangGenerator.php:88

    Should not access $GLOBALS['TSFE'] directly Use call of the available method getTypoScriptFrontendController()? Example: $this->getTypoScriptFrontendController()->->additionalHeaderData[] = implode(LF, $hreflangs);
  8. Steffen Frese uploaded patch set 4 04/11/19, 11:25

  9. TYPO3com voted on patch set 4 V +1 04/11/19, 11:40 Completed build in 15m 04s on Thu, 11 Apr, 01:40 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33194

  10. Jörg Bösche voted on patch set 4 V +1 CR +1 04/11/19, 11:41

  11. Richard Haeser voted on patch set 4 V +2 CR +2 04/12/19, 18:33

  12. Richard Haeser merged patch set 5 04/12/19, 18:33