60356[BUGFIX] Fill alternative language keys correctly
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Moritz Ngo +1
- Benjamin Kott +1
-
Verified V +2 Done
- Georg Ringer +2
- Moritz Ngo +1
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1518
-
Jan Delius uploaded patch set 1 04/01/19, 11:31
-
TYPO3com voted on patch set 1 V +1 04/01/19, 11:41 Completed build in 10m 12s on Mon, 1 Apr, 01:41 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33021
-
Oliver Klee commented on patch set 1 04/01/19, 12:24
This needs to be covered with tests. -
Jan Delius commented on patch set 1 04/01/19, 12:43
> Patch Set 1: > > This needs to be covered with tests. Since I don't know exactly how this place works, I'm the wrong one for testing. The bugfix was taken from the TYPO3 V7 or the TYPO3 V8, where this place still worked without problems. After the change i can call the frontend and the correct language files are loaded. -
Moritz Ngo commented on patch set 1 CR -1 07/29/19, 13:09
If config.language_alt is (still) present it should add to the array to instead of overwriting the array with a string.LocalizationUtility.php:204This should add to the array, too... or am I wrong? $languageKeys['alternativeLanguageKeys'][] = $tsfe->config['config']['language_alt']; -
Jan Delius uploaded patch set 2 07/29/19, 13:37
-
TYPO3com voted on patch set 2 V -1 07/29/19, 13:38 Completed build in 10s on Mon, 29 Jul, 03:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35364
-
Jan Delius commented on patch set 2 07/29/19, 13:39
> Patch Set 1: Code-Review-1 > > (1 comment) > > If config.language_alt is (still) present it should add to the array to instead of overwriting the array with a string.LocalizationUtility.php:204ReplyThis is true -
Jan Delius uploaded patch set 3 07/29/19, 13:56
-
Jan Delius commented on patch set 3 07/29/19, 13:58
> Patch Set 1: Code-Review-1 > > (1 comment) > > If config.language_alt is (still) present it should add to the array to instead of overwriting the array with a string. After rebase the deprecated settings are removed now -
TYPO3com voted on patch set 3 V +1 07/29/19, 14:05 Completed build in 09m 31s on Mon, 29 Jul, 04:05 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35366
-
Moritz Ngo commented on patch set 3 V +1 CR +1 07/30/19, 16:20
Works for meLocalizationUtility.php:204ReplyAck -
Georg Ringer voted on patch set 3 V +2 CR +2 08/02/19, 18:40
-
Georg Ringer voted on patch set 3 V +1 CR +1 08/02/19, 18:40
-
Georg Ringer commented on patch set 3 08/02/19, 18:41
how to reproduce, see issue -
Benjamin Kott voted on patch set 3 V +1 CR +1 08/02/19, 18:51
-
Georg Ringer voted on patch set 3 V +2 CR +2 08/02/19, 18:52
-
Georg Ringer merged patch set 4 08/02/19, 18:52