Review main Merged

60357[BUGFIX] Check if fileObject width is greater than 0, if not use maxWidth

Riny van Tiggelen CR +2 V +2 Easy +2 −1 updated 04/02/19, 09:22

Commit message

If you want to use a PDF inside the GalleryProcessor, the mediaWidth is
always 0, because there are no dimensions in the metadata. This fix
will use the maxMediaWidth if the dimension is not greater than 0.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Frans Saris +1
    • Koen Wouters +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Koen Wouters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Riny van Tiggelen uploaded patch set 1 04/01/19, 16:07

  2. TYPO3com voted on patch set 1 V +1 04/01/19, 16:23 Completed build in 15m 45s on Mon, 1 Apr, 06:23 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33022

  3. Frans Saris voted on patch set 1 CR +1 04/01/19, 17:03

  4. Richard Haeser voted on patch set 1 V +1 CR +1 04/01/19, 18:30

  5. Koen Wouters voted on patch set 1 V +1 CR +1 04/02/19, 08:36

  6. Richard Haeser voted on patch set 1 V +2 CR +2 04/02/19, 09:22

  7. Richard Haeser merged patch set 2 04/02/19, 09:22