60362[BUGFIX] Make unique id for same checkboxes in different sections
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
- Guido Schmechel +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1316
-
Dmytro Nozdrin uploaded patch set 1 04/03/19, 08:43
-
TYPO3com voted on patch set 1 V +1 04/03/19, 09:00 Completed build in 16m 20s on Wed, 3 Apr, 11:00 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33027
-
Oliver Klee commented on patch set 1 04/05/19, 08:11
Can we cover this with tests? -
Raphael Thanner commented on patch set 1 04/05/19, 11:55
Does it really make sense to have the same checkbox in different sections? Because the checkboxes in sections lower in DOM will override the value of the checkboxes above? The field name itself is already unique, or do i misunderstand the issue? -
Dmytro Nozdrin commented on patch set 1 04/05/19, 12:14
> Patch Set 1: > > Does it really make sense to have the same checkbox in different sections? Because the checkboxes in sections lower in DOM will override the value of the checkboxes above? > > The field name itself is already unique, or do i misunderstand the issue? There is a sense. It's generally related to ext:flux feature. Here is the discussion https://github.com/FluidTYPO3/flux/issues/1624 The checkboxes had different name attribute while their identifiers were equal. As far as input values of the checkboxes are handled via JavaScript by id's, it wasn't possible to make set the first one without affecting others -
Susi Moog voted on patch set 1 CR +1 12/20/19, 07:55
-
Susi Moog updated the commit message in patch set 2 12/20/19, 07:55
-
Susi Moog voted on patch set 2 CR +1 12/20/19, 07:56
-
TYPO3com voted on patch set 2 V +1 12/20/19, 08:07 Completed build in 11m 17s on Fri, 20 Dec, 08:07 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39544
-
Guido Schmechel rebased onto patch set 3 12/28/19, 14:06
-
TYPO3com voted on patch set 3 V +1 12/28/19, 14:17 Completed build in 10m 33s on Sat, 28 Dec, 02:17 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39640
-
Guido Schmechel commented on patch set 3 V +1 CR +1 12/28/19, 14:21
(Only rebased) -
Oliver Klee wrote 12/30/19, 15:54
Removed reviewer Oliver Klee. -
Georg Ringer voted on patch set 3 V +1 CR +1 12/30/19, 19:29
-
Susi Moog voted on patch set 3 V +2 CR +2 01/24/20, 18:04
-
Susi Moog merged patch set 4 01/24/20, 18:04