Review main Merged

60363[TASK] Prepare Frontend Tests for additional site handling tests

Benni Mack CR +2 V +2 Hard +237 −198 updated 04/03/19, 15:18

Commit message

Some test functionality regarding Site Handling is now sorted out in order
to add more tests.

- SiteConfiguration setup for tests is moved into a separate Trait.
- Code which is also used (in the future) for EXT:core and not
   just frontend is moved to EXT:core
- LocalizedFrontendPages now have a slug field as well.
- Regular Frontend JsonRenderer now also renders values
  from SiteLanguage config + context aspect

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 812

  1. Benni Mack uploaded patch set 1 04/03/19, 09:56

  2. TYPO3com voted on patch set 1 V -1 04/03/19, 10:11 Completed build in 15m 39s on Wed, 3 Apr, 12:11 PM Test Summary: 102 of 47650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33028

  3. Benni Mack uploaded patch set 2 04/03/19, 10:29

  4. TYPO3com voted on patch set 2 V -1 04/03/19, 10:44 Completed build in 15m 15s on Wed, 3 Apr, 12:44 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33029

  5. TYPO3com commented on patch set 2 04/03/19, 10:53 Completed build in 39m 09s on Wed, 3 Apr, 12:53 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33029

  6. Benni Mack uploaded patch set 3 04/03/19, 10:54

  7. TYPO3com voted on patch set 3 V +1 04/03/19, 11:10 Completed build in 15m 27s on Wed, 3 Apr, 01:10 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33030

  8. Andreas Kienast voted on patch set 3 CR +1 04/03/19, 12:05

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 04/03/19, 13:15

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 04/03/19, 14:12

  11. Anja Leichsenring merged patch set 4 04/03/19, 14:12

  12. Oliver Hader voted on patch set 4 CR +1 04/03/19, 15:18