Review 9.5 Merged

60364[BUGFIX] Enable preview of hidden page translations

Benni Mack CR +2 V +2 Easy +18 −7 updated 04/03/19, 14:06

Commit message

TSFE->determineIdIsHiddenPage() now takes the current site language into
account when fetching the page record. When rendering a page translation
the method does no longer reflect the hidden status of the default
language but the status of the translated page instead.

This enables previewing a hidden page translation even if the language
parent is active.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 04/03/19, 11:44

  2. TYPO3com voted on patch set 1 V +1 04/03/19, 11:55 Completed build in 11m 12s on Wed, 3 Apr, 01:55 PM Test Summary: 49968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-436

  3. Daniel Goerz uploaded patch set 2 04/03/19, 13:43

  4. TYPO3com voted on patch set 2 V +1 04/03/19, 13:55 Completed build in 11m 45s on Wed, 3 Apr, 03:55 PM Test Summary: 49968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-437

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 04/03/19, 14:03

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/03/19, 14:05

  7. Benni Mack merged patch set 3 04/03/19, 14:06