Review main Merged

60368[TASK] Update columns in DocHeader bar

Koen Wouters CR +2 V +2 Easy +2 −2 updated 04/08/19, 18:46

Commit message

Dropdown fields will now stay next to each other for
responsive views.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • André Buchmann +1
  • Verified V +2 Done
    • Richard Haeser +2
    • André Buchmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Koen Wouters uploaded patch set 1 04/03/19, 18:52

  2. Koen Wouters uploaded patch set 2 04/03/19, 18:58

  3. TYPO3com voted on patch set 1 V +1 04/03/19, 19:10 Completed build in 17m 47s on Wed, 3 Apr, 09:10 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33035

  4. Riccardo De Contardi commented on patch set 2 V +1 04/03/19, 19:10

    verified on Master
  5. TYPO3com voted on patch set 2 V +1 04/03/19, 19:15 Completed build in 16m 56s on Wed, 3 Apr, 09:15 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33036

  6. Joerg Kummer voted on patch set 2 V +1 CR +1 04/03/19, 21:14

  7. Daniel Goerz commented on patch set 2 V -1 04/04/19, 07:17

    This changes the rendering for a normal or wide display. The select boxes are now rendered much wider (because of the change from md-3 to md-6)
  8. Chau kar Man voted on patch set 2 V +1 04/05/19, 10:46

  9. Chau kar Man voted on patch set 2 CR +1 04/05/19, 10:46

  10. André Buchmann commented on patch set 2 CR -1 04/05/19, 16:37

    > Patch Set 2: Verified-1 > > This changes the rendering for a normal or wide display. The select boxes are now rendered much wider (because of the change from md-3 to md-6) What about adding col-lg-4 for the left column and col-lg-8 for the right? col-lg-3 is to small on screens between 1730px and 1750px.
  11. Koen Wouters uploaded patch set 3 04/08/19, 17:16

  12. TYPO3com voted on patch set 3 V +1 04/08/19, 17:32 Completed build in 15m 09s on Mon, 8 Apr, 07:32 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33120

  13. André Buchmann voted on patch set 3 V +1 CR +1 04/08/19, 17:52

  14. Richard Haeser voted on patch set 3 V +2 CR +2 04/08/19, 18:46

  15. Richard Haeser merged patch set 4 04/08/19, 18:46