Review main Merged

60370[BUGFIX] ImmediateResponseException needs to be relayed

Jonas Schwabe CR +2 V +2 Normal +62 −0 updated 07/01/19, 07:11

Commit message

ImmediateResponseException were not handled correctly during content
object rendering when running in a production environment.
This patch makes sure that ImmediateResponses are handled as such instead
of just printing them during template rendering.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jonas Schwabe +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jonas Schwabe +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1320

  1. Jonas Schwabe uploaded patch set 1 04/04/19, 10:27

  2. TYPO3com voted on patch set 1 V -1 04/04/19, 10:42 Completed build in 15m 40s on Thu, 4 Apr, 12:43 PM Test Summary: 47261 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33041

  3. Jonas Schwabe uploaded patch set 2 04/04/19, 10:50

  4. TYPO3com voted on patch set 2 V +1 04/04/19, 11:07 Completed build in 15m 59s on Thu, 4 Apr, 01:07 PM Test Summary: 47261 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33042

  5. Anja Leichsenring updated the commit message in patch set 3 04/05/19, 17:37

  6. TYPO3com voted on patch set 3 V +1 04/05/19, 17:52 Completed build in 15m 17s on Fri, 5 Apr, 07:52 PM Test Summary: 47271 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33084

  7. Jörg Bösche voted on patch set 3 CR +1 04/08/19, 10:46

  8. Daniel Goerz voted on patch set 3 CR +1 06/28/19, 19:12

  9. Daniel Goerz commented on patch set 3 CR 0 06/28/19, 19:17

    ProductionExceptionHandler.php:75

    Let's move this to the very beginning of the method, so no log entry is created
  10. Daniel Goerz commented on patch set 4 06/29/19, 11:59

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V -1 06/29/19, 12:12 Completed build in 13m 01s on Sat, 29 Jun, 02:12 PM Test Summary: 7580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34640

  12. TYPO3com commented on patch set 4 06/29/19, 12:35 Completed build in 14m 16s on Sat, 29 Jun, 02:35 PM Test Summary: 7580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34642

  13. Daniel Goerz uploaded patch set 5 06/29/19, 12:47

  14. TYPO3com commented on patch set 4 06/29/19, 12:49 Completed build in 10m 28s on Sat, 29 Jun, 02:49 PM Test Summary: 7580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34644

  15. TYPO3com voted on patch set 5 V +1 06/29/19, 12:58 Completed build in 10m 33s on Sat, 29 Jun, 02:58 PM Test Summary: 46836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34645

  16. Jonas Schwabe commented on patch set 5 06/29/19, 14:56

    ProductionExceptionHandler.php:75 Reply

    You are right, logging makes no sense. Thanks for updating the branch.
  17. Benni Mack voted on patch set 5 V +1 CR +1 07/01/19, 04:18

  18. Jonas Schwabe voted on patch set 5 V +1 CR +1 07/01/19, 06:59

  19. Daniel Goerz voted on patch set 5 V +2 CR +2 07/01/19, 07:11

  20. Daniel Goerz merged patch set 6 07/01/19, 07:11