Review main Merged

60371[BUGFIX] Use proper path to install cli binary

Helmut Hummel CR +2 V +2 Normal +70 −28 updated 04/11/19, 07:18

Commit message

The cli binary path is changed to be located in TYPO3_PATH_WEB
instead of TYPO3_PATH_ROOT.

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Jörg Bösche +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1118

  1. Helmut Hummel uploaded patch set 1 04/04/19, 14:42

  2. TYPO3com voted on patch set 1 V -1 04/04/19, 14:42 Completed build in 11s on Thu, 4 Apr, 04:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33043

  3. Helmut Hummel uploaded patch set 2 04/04/19, 14:42

  4. TYPO3com voted on patch set 2 V -1 04/04/19, 14:43 Completed build in 11s on Thu, 4 Apr, 04:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33044

  5. Helmut Hummel uploaded patch set 3 04/04/19, 14:43

  6. TYPO3com voted on patch set 3 V -1 04/04/19, 14:53 Completed build in 08m 54s on Thu, 4 Apr, 04:53 PM Test Summary: 2 of 47650 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33045

  7. Oliver Klee commented on patch set 3 CR -1 04/04/19, 15:07

    The issue number seems to be missing.
  8. TYPO3com voted on patch set 3 V +1 04/04/19, 19:07 Completed build in 4h 32m 12s on Thu, 4 Apr, 09:07 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33045

  9. Helmut Hummel updated the commit message in patch set 4 04/05/19, 08:38

  10. TYPO3com voted on patch set 4 V +1 04/05/19, 08:53 Completed build in 15m 00s on Fri, 5 Apr, 10:53 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33048

  11. Jörg Bösche uploaded patch set 5 04/08/19, 12:57

  12. TYPO3com voted on patch set 5 V +1 04/08/19, 13:13 Completed build in 15m 44s on Mon, 8 Apr, 03:13 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33117

  13. Jörg Bösche uploaded patch set 6 04/08/19, 13:44

  14. TYPO3com voted on patch set 6 V +1 04/08/19, 14:00 Completed build in 15m 21s on Mon, 8 Apr, 04:00 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33118

  15. Tobi Kretschmann voted on patch set 6 V +2 CR +2 04/08/19, 14:01

  16. Benni Mack voted on patch set 6 V +1 CR +1 04/11/19, 06:22

  17. Jörg Bösche voted on patch set 6 V +1 CR +1 04/11/19, 06:29

  18. Tobi Kretschmann merged patch set 7 04/11/19, 07:18