Review main Merged

60372[BUGFIX] Reenable Page TSconfig setting mod.web_list.hideTranslations

Jan Helke CR +2 V +2 Easy +1 −1 updated 04/08/19, 09:47

Commit message

This regression fix reenables the setting mod.web_list.hideTranslations to
enable administrators to hide translations in the list view.
This behaviour is already described under
https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Daniel Windloff +1
    • Sebastian Rosskopf +1
    • Jochen Roth +1
    • Raphael Thanner +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Daniel Windloff +1
    • Sebastian Rosskopf +1
    • Jochen Roth +1
    • Raphael Thanner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Jan Helke uploaded patch set 1 04/05/19, 07:38

  2. TYPO3com voted on patch set 1 V +1 04/05/19, 07:54 Completed build in 16m 22s on Fri, 5 Apr, 09:54 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33046

  3. Felix Herrmann commented on patch set 1 04/05/19, 09:22

    We are confused due to the documentation on https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html#hidetranslations "Only records in default website languages are visible" We created some tt_content elements in 2 language one as translation and one in free mode. The "free mode" records are still visible in contrary to documentation. Is that a problem? Should the documentation be adjusted?
  4. André Buchmann uploaded patch set 2 04/05/19, 09:24

  5. André Buchmann commented on patch set 2 04/05/19, 09:27

    As the compare $this->hideTranslations === '*' is faster than GeneralUtility::inList($this->hideTranslations, $table) we changed the order. Typos in commit message fixed.
  6. Sebastian Rosskopf voted on patch set 2 V +1 CR +1 04/05/19, 09:28

  7. Jochen Roth voted on patch set 2 V +1 CR +1 04/05/19, 09:29

  8. Raphael Thanner voted on patch set 2 V +1 CR +1 04/05/19, 09:31

  9. TYPO3com voted on patch set 2 V +1 04/05/19, 09:43 Completed build in 18m 54s on Fri, 5 Apr, 11:43 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33050

  10. Daniel Windloff commented on patch set 2 04/05/19, 12:37

    > Patch Set 1: > > We are confused due to the documentation on > https://docs.typo3.org/typo3cms/TSconfigReference/PageTsconfig/Mod.html#hidetranslations > "Only records in default website languages are visible" > > We created some tt_content elements in 2 language one as translation and one in free mode. The "free mode" records are still visible in contrary to documentation. Is that a problem? Should the documentation be adjusted? Clarify documentation: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TSconfig/pull/103/commits/041f077d39dc01304d681b0a36903e0f8e353bd1
  11. Daniel Windloff voted on patch set 2 V +1 CR +1 04/05/19, 12:39

  12. Steffen Frese voted on patch set 2 CR +1 04/08/19, 08:54

  13. Daniel Goerz voted on patch set 2 V +2 CR +2 04/08/19, 09:47

  14. Daniel Goerz merged patch set 3 04/08/19, 09:47