Review main Merged

60373[BUGFIX] Show correct timestamp in file replace dialog

Manuel Selbach CR +2 V +2 Easy +15 −7 updated 04/05/19, 10:33

Commit message

The property lastModifiedDate was remove by some browsers, thus with
this change if will be checked and the proper property is used to
parse the timestamp in the replace dialog.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Felix Herrmann +1
    • Wolf-Peter Utz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Felix Herrmann +1
    • Wolf-Peter Utz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Manuel Selbach uploaded patch set 1 04/05/19, 08:35

  2. TYPO3com voted on patch set 1 V +1 04/05/19, 08:49 Completed build in 13m 34s on Fri, 5 Apr, 10:49 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33047

  3. Andreas Kienast uploaded patch set 2 04/05/19, 09:26

  4. Andreas Kienast uploaded patch set 3 04/05/19, 09:27

  5. TYPO3com voted on patch set 2 V +1 04/05/19, 09:45 Completed build in 18m 24s on Fri, 5 Apr, 11:45 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33051

  6. TYPO3com voted on patch set 3 V +1 04/05/19, 09:45 Completed build in 14m 41s on Fri, 5 Apr, 11:45 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33052

  7. Felix Herrmann commented on patch set 3 V +1 CR +1 04/05/19, 09:52

    tested in Firefox 66.0.2, Chrome 73 and Safari 12.0.3
  8. Wolf-Peter Utz voted on patch set 3 V +1 CR +1 04/05/19, 09:52

  9. Andreas Kienast voted on patch set 3 V +1 CR +1 04/05/19, 10:31

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 04/05/19, 10:33

  11. Andreas Kienast merged patch set 4 04/05/19, 10:33