Review main Merged

60374[BUGFIX] Remove hard coded path to LocalConfiguration.php

Helmut Hummel CR +2 V +2 Easy +1 −1 updated 04/05/19, 19:13

Commit message

Instead of hard coding the path, the ConfigurationManager API
ist now used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sebastian Rosskopf +1
    • Wolf-Peter Utz +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sebastian Rosskopf +1
    • Wolf-Peter Utz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Helmut Hummel uploaded patch set 1 04/05/19, 09:00

  2. TYPO3com voted on patch set 1 V +1 04/05/19, 09:16 Completed build in 15m 47s on Fri, 5 Apr, 11:16 AM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33049

  3. Xavier Perseguers commented on patch set 1 CR +1 04/05/19, 09:42

    Unresolved

    nitpicking but "ist" (German) => "is"
  4. Wolf-Peter Utz commented on patch set 1 V +1 CR +1 04/05/19, 10:40

    Tested successfully with TYPO3 master and 9.5.
  5. Sebastian Rosskopf voted on patch set 1 V +1 CR +1 04/05/19, 11:07

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/05/19, 11:38

  7. Benni Mack merged patch set 2 04/05/19, 11:38

  8. Helmut Hummel commented on patch set 2 04/05/19, 19:13

    Thanks for the swift reviews and the merge!