Review main Merged

60377[BUGFIX] Improved visibility error message in install tool

Chau kar Man CR +2 V +2 Easy +4 −3 updated 04/05/19, 12:41

Commit message

Removed the absolute positioning of the error page to avoid unexpected
behavior when rendered in an encapsulated component, e.g. panels in the
Install Tool.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1318

  1. Chau kar Man uploaded patch set 1 04/05/19, 10:37

  2. Susi Moog updated the commit message in patch set 2 04/05/19, 10:57

  3. TYPO3com voted on patch set 1 V -1 04/05/19, 10:59 Completed build in 21m 55s on Fri, 5 Apr, 12:59 PM Test Summary: 43954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33057

  4. Andreas Kienast commented on patch set 2 CR -1 04/05/19, 11:02

    I think we need a different solution here, this change affect all panels in the Install Tool.
  5. Andreas Kienast commented on patch set 2 04/05/19, 11:10

    Will try to adjust the error page itself instead
  6. TYPO3com voted on patch set 2 V -1 04/05/19, 11:19 Completed build in 14m 35s on Fri, 5 Apr, 01:19 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33059

  7. Andreas Kienast uploaded patch set 3 04/05/19, 11:29

  8. Andreas Kienast uploaded patch set 4 04/05/19, 11:30

  9. Wolf-Peter Utz voted on patch set 4 V +1 CR +1 04/05/19, 11:39

  10. Felix Herrmann voted on patch set 4 V +1 CR +1 04/05/19, 11:43

  11. TYPO3com voted on patch set 4 V +1 04/05/19, 11:46 Completed build in 16m 03s on Fri, 5 Apr, 01:46 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33061

  12. TYPO3com voted on patch set 3 V +1 04/05/19, 11:51 Completed build in 21m 41s on Fri, 5 Apr, 01:51 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33060

  13. Andreas Kienast uploaded patch set 5 04/05/19, 12:15

  14. Benjamin Kott commented on patch set 5 V +1 CR +1 04/05/19, 12:17

    Solves the problem for now. The REM to
  15. TYPO3com voted on patch set 5 V +1 04/05/19, 12:33 Completed build in 17m 53s on Fri, 5 Apr, 02:33 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33064

  16. Markus Klein voted on patch set 5 V +1 CR +1 04/05/19, 12:37

  17. Andreas Kienast voted on patch set 5 V +2 CR +2 04/05/19, 12:41

  18. Andreas Kienast merged patch set 6 04/05/19, 12:41