Review main Merged

60409[BUGFIX] Correct link parsing with anchor and params

Thorben Nissen CR +2 V +2 Easy +20 −3 updated 11/29/19, 12:43

Commit message

Adds parsing of link to ensure correct order of query params and anchor.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1015

  1. Thorben Nissen uploaded patch set 1 04/06/19, 12:54

  2. TYPO3com voted on patch set 1 V +1 04/06/19, 13:04 Completed build in 09m 55s on Sat, 6 Apr, 03:04 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33099

  3. Thorben Nissen uploaded patch set 2 04/06/19, 13:14

  4. TYPO3com voted on patch set 2 V +1 04/06/19, 13:27 Completed build in 12m 36s on Sat, 6 Apr, 03:27 PM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33100

  5. Jörg Bösche voted on patch set 2 CR +1 04/08/19, 10:40

  6. Andreas Kienast uploaded patch set 3 10/26/19, 07:27

  7. Susi Moog updated the commit message in patch set 4 10/26/19, 07:33

  8. TYPO3com voted on patch set 3 V +1 10/26/19, 07:48 Completed build in 16m 40s on Sat, 26 Oct, 07:48 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37758

  9. TYPO3com voted on patch set 4 V +1 10/26/19, 07:55 Completed build in 13m 10s on Sat, 26 Oct, 07:55 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37760

  10. Susi Moog commented on patch set 4 CR -1 11/29/19, 12:19

    After applying the patch, the link params get appended to the anchor _and_ prepended: t3://page?uid=1&baz=bencer#211baz=bencer - destroying the anchor in turn.
  11. Andreas Kienast uploaded patch set 5 11/29/19, 12:22

  12. Susi Moog voted on patch set 5 V +1 CR +1 11/29/19, 12:26

  13. TYPO3com voted on patch set 5 V +1 11/29/19, 12:35 Completed build in 13m 10s on Fri, 29 Nov, 12:35 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38935

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 11/29/19, 12:43

  15. Andreas Kienast merged patch set 6 11/29/19, 12:43