Review TYPO3_8-7 Merged

60410[TASK] Fix scroll behaviour of "Uncaught Exceptions" in backend

TYPO3com CR +2 V +2 Easy +3 −0 updated 07/12/19, 14:01

Commit message

In the TYPO3 Backend of version 8, the iframe page (id
"typo3-contentIframe") is not scrollable, when an "uncaught exception" is
thrown and its content exceeds the page. The simplest way to fix this
behavior seems to be by adding 3 CSS rules to the very first div element
after the body tag in the iframe page (right, max-height and overflow;
"right" is needed to enable horizontal scrolling).

This solution is not perfect, when it comes to horizontal scrolling - but
better than the current situation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Jonas Eberle +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 04/06/19, 13:35

  2. TYPO3com voted on patch set 1 V +1 04/06/19, 13:58 Completed build in 23m 13s on Sat, 6 Apr, 03:58 PM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3457

  3. Jörg Bösche updated the commit message in patch set 2 04/08/19, 08:44

  4. TYPO3com voted on patch set 2 V +1 04/08/19, 09:04 Completed build in 19m 36s on Mon, 8 Apr, 11:04 AM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3458

  5. Oliver Klee commented on patch set 2 04/08/19, 10:25

    DebugExceptionHandler.php:96

    Please use the same indentation as the surrounding code (tabs). (And yes, I know that the whole section should be changed from tabs to spaces.)
  6. Jörg Bösche commented on patch set 3 04/08/19, 10:30

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 04/08/19, 10:53 Completed build in 23m 20s on Mon, 8 Apr, 12:53 PM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3459

  8. Oliver Klee voted on patch set 3 CR +1 05/03/19, 12:39

  9. Jonas Eberle commented on patch set 3 V +1 CR +1 06/28/19, 18:41

    IMHO this could be changed to [BUGFIX]
  10. Simon Gilli voted on patch set 3 CR +1 07/01/19, 10:59

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/12/19, 14:00

  12. Benni Mack merged patch set 4 07/12/19, 14:00

  13. Benni Mack commented on patch set 4 07/12/19, 14:01

    ah, crap. it's a "Bugfix" - not a "TASK"