Review main Merged

60411[TASK] Upgrade Symfony-components

Stefan Neufeind CR +2 V +2 Hard +254 −172 updated 06/05/19, 04:40

Commit message

Command used:
composer update symfony/* --with-dependencies

Following dependencies changed:
- Installing symfony/polyfill-php73 (v1.11.0)
- Updating symfony/polyfill-mbstring (v1.10.0 => v1.11.0)
- Updating symfony/console (v4.2.3 => v4.3.0)
- Installing symfony/var-exporter (v4.3.0)
- Updating symfony/cache (v4.1.4 => v4.3.0)
- Updating symfony/expression-language (v4.1.4 => v4.3.0)
- Updating symfony/finder (v4.2.3 => v4.3.0)
- Updating symfony/polyfill-php72 (v1.10.0 => v1.11.0)
- Updating symfony/polyfill-intl-idn (v1.10.0 => v1.11.0)
- Updating symfony/inflector (v4.2.2 => v4.3.0)
- Updating symfony/property-access (v4.2.2 => v4.3.0)
- Updating symfony/property-info (v4.2.2 => v4.3.0)
- Updating symfony/routing (v4.1.4 => v4.3.0)
- Updating symfony/yaml (v4.1.4 => v4.3.0)
- Updating symfony/filesystem (v4.2.3 => v4.3.0)
- Updating symfony/options-resolver (v4.2.3 => v4.3.0)
- Updating symfony/polyfill-php70 (v1.10.0 => v1.11.0)
- Updating symfony/stopwatch (v4.2.3 => v4.3.0)
- Updating symfony/intl (v4.1.4 => v4.3.0)
- Updating symfony/polyfill-intl-icu (v1.9.0 => v1.11.0)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2632

Show 47 earlier messages
  1. Stefan Neufeind uploaded patch set 1 04/07/19, 09:33

  2. TYPO3com voted on patch set 1 V +1 04/07/19, 09:49 Completed build in 15m 13s on Sun, 7 Apr, 11:49 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33101

  3. Stefan Neufeind uploaded patch set 2 04/16/19, 10:59

  4. TYPO3com voted on patch set 2 V +1 04/16/19, 11:12 Completed build in 13m 25s on Tue, 16 Apr, 01:12 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33292

  5. Stefan Neufeind uploaded patch set 3 04/18/19, 07:14

  6. TYPO3com voted on patch set 3 V -1 04/18/19, 08:05 Completed build in 39m 58s on Thu, 18 Apr, 10:05 AM Test Summary: 151 of 47866 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33330

  7. Andreas Kienast commented on patch set 3 04/18/19, 08:23

    The latest upgrade of symfony/routing is also needed in 9.5, since a security change breaks our routing right now.
  1. Stefan Neufeind uploaded patch set 4 05/30/19, 12:56

  2. Stefan Neufeind commented on patch set 4 05/30/19, 12:58

    update for Symfony 4.3.0 now. Upgrade of base-packages will be basis for other works regarding new Symfony-componentes (like the new Mailer instead of SwiftMailer)
  3. Stefan Neufeind commented on patch set 4 05/30/19, 13:03

    @Andreas: The issue with symfony/routing seems to be addressed in newer Symfony-releases. https://github.com/symfony/symfony/pull/31107#issuecomment-484681404 There was a commit from Susi to block 4.2.7 due to the breaking change in symfony. commit 389bb4071326fc6cf374e86a9b2c51ff436e904e Author: Susanne Moog <susanne.moog@typo3.com> Date: Thu Apr 18 22:49:14 2019 +0200 [BUGFIX] Mark symfony/routing 4.2.7 as conflict
  4. Oliver Klee commented on patch set 4 CR +1 05/30/19, 13:04

    If parts of our code rely on the new versions, we'll need to update composer.json, too, and set the required minimum versions there first.
  5. Oliver Klee voted on patch set 4 CR -1 05/30/19, 13:04

  6. Stefan Neufeind commented on patch set 4 05/30/19, 13:12

    @Oliver: This update is just what composer.json currently allows anyway. It's just updates within in the constraints set by composer.json.
  7. TYPO3com voted on patch set 4 V +1 05/30/19, 13:12 Completed build in 15m 32s on Thu, 30 May, 03:12 PM Test Summary: 46470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34104

  8. Stefan Neufeind commented on patch set 4 05/30/19, 13:13

    Once we explicitly require something from 4.3.0 I agree with you. However that's not part of this patch. You can still go with the old packages, according to composer.json.
  9. Oliver Klee commented on patch set 4 05/30/19, 14:06

    So using the old package versions (e.g., with a Composer-based setup) will not break anything? I understood the comment "The latest upgrade of symfony/routing is also needed in 9.5, since a security change breaks our routing right now." that this update is required to unbreak the routing. Am I mistaken?
  10. Georg Ringer commented on patch set 4 CR -1 05/30/19, 17:59

    Please also state which packages are upgraded from which version to which.
  11. Stefan Neufeind commented on patch set 4 05/31/19, 10:01

    Removing symfony/contracts (v1.0.2) Removing psr/simple-cache (1.0.1) Installing symfony/service-contracts (v1.1.2) Installing symfony/polyfill-php73 (v1.11.0) Updating symfony/polyfill-mbstring (v1.10.0 => v1.11.0) Updating symfony/console (v4.2.3 => v4.3.0) Installing symfony/var-exporter (v4.3.0) Installing symfony/cache-contracts (v1.1.1) Updating symfony/cache (v4.1.4 => v4.3.0) Updating symfony/expression-language (v4.1.4 => v4.3.0) Updating symfony/finder (v4.2.3 => v4.3.0) Updating symfony/polyfill-intl-icu (v1.9.0 => v1.11.0) Updating symfony/intl (v4.1.4 => v4.3.0) Updating symfony/polyfill-php72 (v1.10.0 => v1.11.0) Updating symfony/polyfill-intl-idn (v1.10.0 => v1.11.0) Updating symfony/polyfill-ctype (v1.10.0 => v1.11.0) Updating symfony/inflector (v4.2.2 => v4.3.0) Updating symfony/property-access (v4.2.2 => v4.3.0) Updating symfony/property-info (v4.2.2 => v4.3.0) Updating symfony/routing (v4.1.4 => v4.3.0) Updating symfony/yaml (v4.1.4 => v4.3.0) Updating symfony/dom-crawler (v4.2.3 => v4.3.0) Updating symfony/browser-kit (v4.2.3 => v4.3.0) Updating symfony/css-selector (v4.2.3 => v4.3.0) Installing symfony/event-dispatcher-contracts (v1.1.1) Updating symfony/event-dispatcher (v4.2.3 => v4.3.0) Updating symfony/filesystem (v4.2.3 => v4.3.0) Updating symfony/options-resolver (v4.2.3 => v4.3.0) Updating symfony/polyfill-php70 (v1.10.0 => v1.11.0) Updating symfony/process (v4.2.3 => v4.3.0) Updating symfony/stopwatch (v4.2.3 => v4.3.0)
  12. Stefan Neufeind commented on patch set 4 05/31/19, 10:03

    @Oli: I understood the comment from Andreas (Apr 18) the way to explain why automatic testing failed. After that there was a patch by Susi blacklisting a certain (broken) version and the linked issue at Symfony says newer versions contain a fix. So that's why now tests work again.
  13. Oliver Klee commented on patch set 4 05/31/19, 10:30

    Andreas, just to be sure: Is Stefan's explanation of your comment correct?
  14. Andreas Kienast commented on patch set 4 05/31/19, 12:31

    > Patch Set 4: > > Andreas, just to be sure: Is Stefan's explanation of your comment correct? I think so, yes. But please check carefully if everything still works, IIRC there were reported issues with updated routing component.
  15. Oliver Klee voted on patch set 4 CR 0 05/31/19, 13:46

  16. Benni Mack updated the commit message in patch set 5 06/03/19, 09:57

  17. Oliver Klee voted on patch set 5 CR +1 06/03/19, 09:58

  18. TYPO3com voted on patch set 5 V +1 06/03/19, 10:12 Completed build in 15m 09s on Mon, 3 Jun, 12:12 PM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34142

  19. Benni Mack uploaded patch set 6 06/04/19, 06:05

  20. TYPO3com voted on patch set 6 V +1 06/04/19, 06:19 Completed build in 13m 28s on Tue, 4 Jun, 08:19 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34163

  21. Oliver Klee voted on patch set 6 CR +1 06/04/19, 09:41

  22. Anja Leichsenring voted on patch set 6 V +1 CR +1 06/04/19, 09:51

  23. Stefan Neufeind commented on patch set 6 V +1 06/04/19, 09:53

    worked for me with basic testing
  24. Benni Mack voted on patch set 6 V +2 CR +2 06/05/19, 04:40

  25. Benni Mack merged patch set 7 06/05/19, 04:40