60418[FEATURE] Add custom generator options via hook
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Georg Ringer +1
-
Verified V +2 Done
- Susi Moog +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1621
-
Benni Mack uploaded patch set 1 04/09/19, 01:29
-
TYPO3com voted on patch set 1 V -1 04/09/19, 01:44 Completed build in 14m 29s on Tue, 9 Apr, 03:44 AM Test Summary: 2 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33123
-
TYPO3com voted on patch set 1 V +1 04/10/19, 03:03 Completed build in 1h 48m 31s on Wed, 10 Apr, 05:03 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33123
-
Tom voted on patch set 1 V +1 CR +1 04/17/19, 18:38
-
Nikolaj Wojtkowiak-Pfänder voted on patch set 1 V +1 CR +1 04/24/19, 07:41
-
Georg Ringer commented on patch set 1 CR -1 04/24/19, 11:20
I would also add $this->tableName & $this->fieldName? -
Daniel Goerz commented on patch set 1 04/24/19, 16:02
This needs to be ['config'] -
Nikolaj Wojtkowiak-Pfänder wrote 04/24/19, 16:09
Removed Code-Review+1 by Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com> -
Daniel Goerz commented on patch set 1 CR -1 04/24/19, 16:11
SlugHelper.php:211I think we want to pass $prefix as wellSlugHelper.php:217This should be called before the hook, or else inside the hook the slug is not in its final form. -
Daniel Goerz commented on patch set 1 04/24/19, 16:14
SlugHelper.php:227Maybe move the hook to this location so the final Slug can be manipulated? Else the $prefix will always be prepended no matter what. -
Daniel Goerz uploaded patch set 2 04/24/19, 17:12
-
TYPO3com voted on patch set 2 V +1 04/24/19, 17:25 Completed build in 13m 13s on Wed, 24 Apr, 07:25 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33385
-
Benni Mack uploaded patch set 3 04/24/19, 17:58
-
TYPO3com voted on patch set 3 V +1 04/24/19, 18:15 Completed build in 16m 21s on Wed, 24 Apr, 08:15 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33387
-
Benni Mack uploaded patch set 4 04/24/19, 18:47
-
TYPO3com voted on patch set 4 V +1 04/24/19, 18:58 Completed build in 10m 15s on Wed, 24 Apr, 08:58 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33389
-
Guido Schmechel commented on patch set 4 04/25/19, 11:24
TODO after Merge and Release (07.05): https://docs.typo3.org/typo3cms/TCAReference/ColumnsConfig/Type/Slug.html -
Georg Ringer voted on patch set 4 V +1 CR +1 04/29/19, 19:33
-
Susi Moog voted on patch set 4 CR +1 04/29/19, 20:30
-
Susi Moog voted on patch set 4 V +2 CR +2 04/29/19, 20:40
-
Susi Moog merged patch set 5 04/29/19, 20:40