Review main Merged

60418[FEATURE] Add custom generator options via hook

Benni Mack CR +2 V +2 Normal +103 −0 updated 04/29/19, 20:40

Commit message

In order to allow custom functionality like "Skip pages of type XYZ", a new
hook is added to the SlugHelper which can be added via

$GLOBALS['TCA']['pages']['columns']['slug']['config']['generatorOptions']['postModifiers']

The userFunc needs to return the new / modified $slug which is then put through the
sanitize() method.

TYPO3 Core does not provide custom functionality so this hook allows
to build everything a custom installation or extension wants to hook in.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Benni Mack uploaded patch set 1 04/09/19, 01:29

  2. TYPO3com voted on patch set 1 V -1 04/09/19, 01:44 Completed build in 14m 29s on Tue, 9 Apr, 03:44 AM Test Summary: 2 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33123

  3. TYPO3com voted on patch set 1 V +1 04/10/19, 03:03 Completed build in 1h 48m 31s on Wed, 10 Apr, 05:03 AM Test Summary: 47267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33123

  4. Tom voted on patch set 1 V +1 CR +1 04/17/19, 18:38

  5. Nikolaj Wojtkowiak-Pfänder voted on patch set 1 V +1 CR +1 04/24/19, 07:41

  6. Georg Ringer commented on patch set 1 CR -1 04/24/19, 11:20

    I would also add $this->tableName & $this->fieldName?
  7. Daniel Goerz commented on patch set 1 04/24/19, 16:02

    This needs to be ['config']
  8. Nikolaj Wojtkowiak-Pfänder wrote 04/24/19, 16:09

    Removed Code-Review+1 by Nikolaj Wojtkowiak-Pfänder <nwp@dr-bock.com>
  9. Daniel Goerz commented on patch set 1 CR -1 04/24/19, 16:11

    SlugHelper.php:211

    I think we want to pass $prefix as well

    SlugHelper.php:217

    This should be called before the hook, or else inside the hook the slug is not in its final form.
  10. Daniel Goerz commented on patch set 1 04/24/19, 16:14

    SlugHelper.php:227

    Maybe move the hook to this location so the final Slug can be manipulated? Else the $prefix will always be prepended no matter what.
  11. Daniel Goerz uploaded patch set 2 04/24/19, 17:12

  12. TYPO3com voted on patch set 2 V +1 04/24/19, 17:25 Completed build in 13m 13s on Wed, 24 Apr, 07:25 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33385

  13. Benni Mack uploaded patch set 3 04/24/19, 17:58

  14. TYPO3com voted on patch set 3 V +1 04/24/19, 18:15 Completed build in 16m 21s on Wed, 24 Apr, 08:15 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33387

  15. Benni Mack uploaded patch set 4 04/24/19, 18:47

  16. TYPO3com voted on patch set 4 V +1 04/24/19, 18:58 Completed build in 10m 15s on Wed, 24 Apr, 08:58 PM Test Summary: 47488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33389

  17. Guido Schmechel commented on patch set 4 04/25/19, 11:24

  18. Georg Ringer voted on patch set 4 V +1 CR +1 04/29/19, 19:33

  19. Susi Moog voted on patch set 4 CR +1 04/29/19, 20:30

  20. Susi Moog voted on patch set 4 V +2 CR +2 04/29/19, 20:40

  21. Susi Moog merged patch set 5 04/29/19, 20:40